Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: chrome/browser/resources/settings/people_page/change_picture.html

Issue 2919893002: [MD Settings] Add ARIA roles to profile image chooser for ChromeVox. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 2
3 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 3 <link rel="import" href="chrome://resources/cr_elements/icons.html">
4 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 4 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
5 <link rel="import" href="chrome://resources/html/util.html"> 5 <link rel="import" href="chrome://resources/html/util.html">
6 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 6 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11 y-keys.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11 y-keys.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-sele ctor.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-sele ctor.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
10 <link rel="import" href="../i18n_setup.html"> 10 <link rel="import" href="../i18n_setup.html">
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 display: block; 92 display: block;
93 margin: 0 auto 0 auto; 93 margin: 0 auto 0 auto;
94 } 94 }
95 </style> 95 </style>
96 <div id="container" class="settings-box" tabindex="0"> 96 <div id="container" class="settings-box" tabindex="0">
97 <iron-a11y-keys keys="up down left right space enter" 97 <iron-a11y-keys keys="up down left right space enter"
98 on-keys-pressed="onKeysPress_"> 98 on-keys-pressed="onKeysPress_">
99 </iron-a11y-keys> 99 </iron-a11y-keys>
100 <div id="availableIcons" class="start"> 100 <div id="availableIcons" class="start">
101 <iron-selector id="selector" on-iron-activate="onImageActivate_" 101 <iron-selector id="selector" on-iron-activate="onImageActivate_"
102 selected-item="{{selectedItem_}}"> 102 selected-item="{{selectedItem_}}" role="radiogroup">
103 <iron-icon id="cameraImage" 103 <iron-icon id="cameraImage" role="radio"
104 data-type$="[[selectionTypesEnum_.CAMERA]]" 104 data-type$="[[selectionTypesEnum_.CAMERA]]"
105 icon="settings:camera-alt" title="$i18n{takePhoto}" 105 icon="settings:camera-alt" title="$i18n{takePhoto}"
106 hidden="[[!cameraPresent_]]"> 106 hidden="[[!cameraPresent_]]">
107 </iron-icon> 107 </iron-icon>
108 <iron-icon data-type$="[[selectionTypesEnum_.FILE]]" 108 <iron-icon data-type$="[[selectionTypesEnum_.FILE]]" role="radio"
109 icon="cr:folder" title="$i18n{chooseFile}"> 109 icon="cr:folder" title="$i18n{chooseFile}">
110 </iron-icon> 110 </iron-icon>
111 <img id="profileImage" 111 <img id="profileImage" role="radio"
112 data-type$="[[selectionTypesEnum_.PROFILE]]" 112 data-type$="[[selectionTypesEnum_.PROFILE]]"
113 src="[[profileImageUrl_]]" title="$i18n{profilePhotoLoading}"> 113 src="[[profileImageUrl_]]" title="$i18n{profilePhotoLoading}">
114 <img id="oldImage" data-type$="[[selectionTypesEnum_.OLD]]" 114 <img id="oldImage" data-type$="[[selectionTypesEnum_.OLD]]"
hcarmona 2017/06/02 00:50:04 nit: remove space at end of line
115 src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]" 115 role="radio" src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]"
116 title="$i18n{oldPhoto}"> 116 title="$i18n{oldPhoto}">
117 <template is="dom-repeat" items="[[defaultImages_]]"> 117 <template is="dom-repeat" items="[[defaultImages_]]">
118 <img data-type$="[[selectionTypesEnum_.DEFAULT]]" 118 <img data-type$="[[selectionTypesEnum_.DEFAULT]]" role="radio"
119 data-default-image-index$="[[index]]" src="[[item.url]]" 119 data-default-image-index$="[[index]]" src="[[item.url]]"
120 title="[[item.title]]"> 120 title="[[item.title]]">
121 </template> 121 </template>
122 </iron-selector> 122 </iron-selector>
123 <template is="dom-if" if="[[isAuthorCreditShown_(selectedItem_)]]"> 123 <template is="dom-if" if="[[isAuthorCreditShown_(selectedItem_)]]">
124 <div id="authorCredit"> 124 <div id="authorCredit">
125 $i18n{authorCredit} 125 $i18n{authorCredit}
126 [[getAuthorName_(selectedItem_, defaultImages_)]] 126 [[getAuthorName_(selectedItem_, defaultImages_)]]
127 <a href="[[getAuthorWebsite_(selectedItem_, defaultImages_)]]" 127 <a href="[[getAuthorWebsite_(selectedItem_, defaultImages_)]]"
128 target="_blank"> 128 target="_blank">
(...skipping 14 matching lines...) Expand all
143 </div> 143 </div>
144 <settings-camera id="camera" 144 <settings-camera id="camera"
145 camera-active="[[isCameraActive_(cameraPresent_, selectedItem_)]]" 145 camera-active="[[isCameraActive_(cameraPresent_, selectedItem_)]]"
146 on-phototaken="onPhotoTaken_"> 146 on-phototaken="onPhotoTaken_">
147 </settings-camera> 147 </settings-camera>
148 </div> 148 </div>
149 </div> 149 </div>
150 </template> 150 </template>
151 <script src="change_picture.js"></script> 151 <script src="change_picture.js"></script>
152 </dom-module> 152 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698