Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issue 2919443002: Use IMMEDIATE_CRASH() instead of CRASH() directly (Closed)

Created:
3 years, 6 months ago by gyuyoung
Modified:
3 years, 6 months ago
Reviewers:
tkent, haraken
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, dominicc+watchlist_chromium.org, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, jchaffraix+rendering, blink-reviews, zoltan1, blink-reviews-layout_chromium.org, sof, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, fmalita+watch_chromium.org, blink-layers+watch_chromium.org, mac-reviews_chromium.org, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IMMEDIATE_CRASH() instead of CRASH() directly As a step to reduce uses of macros defined in wtf/Assertions.h, this CL cleans all uses of CRASH() up. Instead we uses IMMEDIATE_CRASH() directly. BUG=596760 Review-Url: https://codereview.chromium.org/2919443002 Cr-Commit-Position: refs/heads/master@{#475978} Committed: https://chromium.googlesource.com/chromium/src/+/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad

Patch Set 1 #

Patch Set 2 : Use IMMEDIATE_CRASH() instead of CRASH() directly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -36 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/BlockExceptions.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/Assertions.h View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/ThreadSpecific.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
gyuyoung
PTAL.
3 years, 6 months ago (2017-05-31 06:35:38 UTC) #2
haraken
LGTM
3 years, 6 months ago (2017-05-31 11:12:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919443002/20001
3 years, 6 months ago (2017-05-31 17:19:08 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad
3 years, 6 months ago (2017-05-31 19:13:56 UTC) #17
tkent
3 years, 6 months ago (2017-05-31 23:09:54 UTC) #18
Message was sent while issue was closed.
I think LOG(FATAL) and LOG_IF(FATAL, condition) are appropriate replacements of
CRASH().

e.g.

if (!client)
  CRASH()

should be

LOG_IF(FATAL, !client);

Powered by Google App Engine
This is Rietveld 408576698