Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: third_party/WebKit/Source/platform/wtf/ThreadSpecific.h

Issue 2919443002: Use IMMEDIATE_CRASH() instead of CRASH() directly (Closed)
Patch Set: Use IMMEDIATE_CRASH() instead of CRASH() directly Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
diff --git a/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h b/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
index 674ad5a565cd42f91a4e6bac5b7c03e6b3e03eea..f1582d949f45a82113f963a4875651084fefbb86 100644
--- a/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
+++ b/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
@@ -126,13 +126,13 @@ inline void ThreadSpecificKeyCreate(ThreadSpecificKey* key,
void (*destructor)(void*)) {
int error = pthread_key_create(key, destructor);
if (error)
- CRASH();
+ IMMEDIATE_CRASH();
}
inline void ThreadSpecificKeyDelete(ThreadSpecificKey key) {
int error = pthread_key_delete(key);
if (error)
- CRASH();
+ IMMEDIATE_CRASH();
}
inline void ThreadSpecificSet(ThreadSpecificKey key, void* value) {
@@ -147,7 +147,7 @@ template <typename T>
inline ThreadSpecific<T>::ThreadSpecific() {
int error = pthread_key_create(&key_, Destroy);
if (error)
- CRASH();
+ IMMEDIATE_CRASH();
}
template <typename T>
@@ -192,11 +192,11 @@ template <typename T>
inline ThreadSpecific<T>::ThreadSpecific() : index_(-1) {
DWORD tls_key = TlsAlloc();
if (tls_key == TLS_OUT_OF_INDEXES)
- CRASH();
+ IMMEDIATE_CRASH();
index_ = InterlockedIncrement(&TlsKeyCount()) - 1;
if (index_ >= kMaxTlsKeySize)
- CRASH();
+ IMMEDIATE_CRASH();
TlsKeys()[index_] = tls_key;
}

Powered by Google App Engine
This is Rietveld 408576698