third_party/WebKit/Source/platform/mac/BlockExceptions.mm - Issue 2919443002: Use IMMEDIATE_CRASH() instead of CRASH() directly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/mac/BlockExceptions.mm

Issue 2919443002: Use IMMEDIATE_CRASH() instead of CRASH() directly (Closed)

Patch Set: Use IMMEDIATE_CRASH() instead of CRASH() directly Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2003, 2007 Apple Inc. All rights reserved.	2 * Copyright (C) 2003, 2007 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 15 matching lines...) Expand all Loading...
26 #import "platform/mac/BlockExceptions.h"	26 #import "platform/mac/BlockExceptions.h"

27	27

28 #import "platform/wtf/Assertions.h"	28 #import "platform/wtf/Assertions.h"

29	29

30 void ReportBlockedObjCException(NSException* exception) {	30 void ReportBlockedObjCException(NSException* exception) {

31 #if DCHECK_IS_ON()	31 #if DCHECK_IS_ON()

32 NOTREACHED() << "Uncaught exception - "	32 NOTREACHED() << "Uncaught exception - "

33 << [[exception description] UTF8String];	33 << [[exception description] UTF8String];

34 // This function is marked as NO_RETURN_DUE_TO_ASSERT, but NOTREACHED() and	34 // This function is marked as NO_RETURN_DUE_TO_ASSERT, but NOTREACHED() and

35 // DCHECK(false) are not recognized as NO_RETURN.	35 // DCHECK(false) are not recognized as NO_RETURN.

36 CRASH();	36 IMMEDIATE_CRASH();

37 #else	37 #else

38 NSLog(@"*** WebKit discarding exception: <%@> %@", [exception name],	38 NSLog(@"*** WebKit discarding exception: <%@> %@", [exception name],

39 [exception reason]);	39 [exception reason]);

40 #endif	40 #endif

41 }	41 }

OLD	NEW