Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2919123002: Reland of DevTools: require enabling CSS domain before running CSS.* commands. (Closed)

Created:
3 years, 6 months ago by engedy
Modified:
3 years, 6 months ago
Reviewers:
yoichio, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of DevTools: require enabling CSS domain before running CSS.* commands. (patchset #1 id:1 of https://codereview.chromium.org/2916283002/ ) Reason for revert: This turned out not to be the culprit. Things just got slow. Original issue's description: > Revert of DevTools: require enabling CSS domain before running CSS.* commands. (patchset #3 id:40001 of https://codereview.chromium.org/2914663002/ ) > > Reason for revert: > It causes layout test failures on Linux: > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/1247 > > Original issue's description: > > DevTools: require enabling CSS domain before running CSS.* commands. > > > > BUG=727795 > > > > Review-Url: https://codereview.chromium.org/2914663002 > > Cr-Commit-Position: refs/heads/master@{#476130} > > Committed: https://chromium.googlesource.com/chromium/src/+/1036888141c747519351828b10ae09984450d871 > > TBR=dgozman@chromium.org,pfeldman@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=727795 > > Review-Url: https://codereview.chromium.org/2916283002 > Cr-Commit-Position: refs/heads/master@{#476608} > Committed: https://chromium.googlesource.com/chromium/src/+/319e041f4fe3cda31cd3cee45f9cb76ab39f7854 TBR=dgozman@chromium.org,pfeldman@chromium.org,yoichio@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=727795 Review-Url: https://codereview.chromium.org/2919123002 Cr-Commit-Position: refs/heads/master@{#476756} Committed: https://chromium.googlesource.com/chromium/src/+/588a6053b5ec770703cd908bb20b3ce4c7ff9ee0

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
engedy
Created Reland of DevTools: require enabling CSS domain before running CSS.* commands.
3 years, 6 months ago (2017-06-02 19:38:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919123002/1
3 years, 6 months ago (2017-06-02 19:38:35 UTC) #3
engedy
Tracking bug for the slowness: https://bugs.chromium.org/p/chromium/issues/detail?id=729136
3 years, 6 months ago (2017-06-02 19:38:56 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 19:39:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/588a6053b5ec770703cd908bb20b...

Powered by Google App Engine
This is Rietveld 408576698