Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2916283002: Revert of DevTools: require enabling CSS domain before running CSS.* commands. (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: require enabling CSS domain before running CSS.* commands. (patchset #3 id:40001 of https://codereview.chromium.org/2914663002/ ) Reason for revert: It causes layout test failures on Linux: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/1247 Original issue's description: > DevTools: require enabling CSS domain before running CSS.* commands. > > BUG=727795 > > Review-Url: https://codereview.chromium.org/2914663002 > Cr-Commit-Position: refs/heads/master@{#476130} > Committed: https://chromium.googlesource.com/chromium/src/+/1036888141c747519351828b10ae09984450d871 TBR=dgozman@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=727795 Review-Url: https://codereview.chromium.org/2916283002 Cr-Commit-Position: refs/heads/master@{#476608} Committed: https://chromium.googlesource.com/chromium/src/+/319e041f4fe3cda31cd3cee45f9cb76ab39f7854

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
yoichio
Created Revert of DevTools: require enabling CSS domain before running CSS.* commands.
3 years, 6 months ago (2017-06-02 05:31:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916283002/1
3 years, 6 months ago (2017-06-02 05:31:39 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/470375)
3 years, 6 months ago (2017-06-02 06:32:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916283002/1
3 years, 6 months ago (2017-06-02 07:39:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/319e041f4fe3cda31cd3cee45f9cb76ab39f7854
3 years, 6 months ago (2017-06-02 09:19:01 UTC) #10
engedy
3 years, 6 months ago (2017-06-02 19:38:04 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2919123002/ by engedy@chromium.org.

The reason for reverting is: This turned out not to be the culprit. Things just
got slow..

Powered by Google App Engine
This is Rietveld 408576698