Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2914663002: DevTools: require enabling CSS domain before running CSS.* commands. (Closed)

Created:
3 years, 6 months ago by pfeldman
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: require enabling CSS domain before running CSS.* commands. BUG=727795 Review-Url: https://codereview.chromium.org/2914663002 Cr-Commit-Position: refs/heads/master@{#476130} Committed: https://chromium.googlesource.com/chromium/src/+/1036888141c747519351828b10ae09984450d871

Patch Set 1 #

Total comments: 1

Patch Set 2 : tests fixed #

Patch Set 3 : same #

Messages

Total messages: 19 (10 generated)
pfeldman
3 years, 6 months ago (2017-05-30 20:53:57 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2914663002/diff/1/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/2914663002/diff/1/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#newcode760 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:760: was_enabled_ = true; It's unfortunate that I have ...
3 years, 6 months ago (2017-05-30 21:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914663002/1
3 years, 6 months ago (2017-05-30 21:11:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/466022)
3 years, 6 months ago (2017-05-30 23:29:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914663002/20001
3 years, 6 months ago (2017-05-31 21:04:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/458397)
3 years, 6 months ago (2017-05-31 23:09:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914663002/40001
3 years, 6 months ago (2017-05-31 23:17:05 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1036888141c747519351828b10ae09984450d871
3 years, 6 months ago (2017-06-01 01:19:45 UTC) #18
yoichio
3 years, 6 months ago (2017-06-02 05:31:27 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2916283002/ by yoichio@chromium.org.

The reason for reverting is: It causes layout test failures on Linux:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu....

Powered by Google App Engine
This is Rietveld 408576698