Add path validation error expectations for PKITS tests.

Add path validation error expectations for PKITS tests.

Also removes some duplication around expected-to-fail PKITS tests.

Review-Url: https://codereview.chromium.org/2918913002
Cr-Commit-Position: refs/heads/master@{#476872}
Committed: https://chromium.googlesource.com/chromium/src/+/605a5cc49fc1e9af1401c48bed56e3f3ece9f2c4

[eroman, 2017-06-01 23:20:07]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[mattm, 2017-06-02 21:09:07]

lgtm with optional nits

https://codereview.chromium.org/2918913002/diff/20001/net/cert/internal/test_...
File net/cert/internal/test_helpers.cc (right):

https://codereview.chromium.org/2918913002/diff/20001/net/cert/internal/test_...
net/cert/internal/test_helpers.cc:311: void VerifyCertPathErrors(const
std::string& expected_errors,
maybe name this expected_errors_str to match actual_errors_str?

https://codereview.chromium.org/2918913002/diff/20001/net/cert/internal/test_...
net/cert/internal/test_helpers.cc:318: if (!matches) {
optional: dunno if using the separate |matches| variable helps, maybe just do
"if (expected_errors != actual_errors_str)"?

[eroman, 2017-06-02 23:16:01]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2017-06-02 23:16:18]

Thanks for the review!

https://codereview.chromium.org/2918913002/diff/20001/net/cert/internal/test_...
File net/cert/internal/test_helpers.cc (right):

https://codereview.chromium.org/2918913002/diff/20001/net/cert/internal/test_...
net/cert/internal/test_helpers.cc:311: void VerifyCertPathErrors(const
std::string& expected_errors,
On 2017/06/02 21:09:07, mattm wrote:
> maybe name this expected_errors_str to match actual_errors_str?

Done.

https://codereview.chromium.org/2918913002/diff/20001/net/cert/internal/test_...
net/cert/internal/test_helpers.cc:318: if (!matches) {
On 2017/06/02 21:09:07, mattm wrote:
> optional: dunno if using the separate |matches| variable helps, maybe just do
> "if (expected_errors != actual_errors_str)"?

Done.

[commit-bot: I haz the power, 2017-06-02 23:16:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-06-02 23:17:26]

BTW, I added one minor change in patchset #4:

https://codereview.chromium.org/2918913002/diff2/40001:60001/net/data/verify_...

[eroman, 2017-06-03 01:10:07]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2017-06-03 01:10:13]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-06-03 01:10:13]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2918913002/#ps80001
(title: "Address Matt's comments")

[commit-bot: I haz the power, 2017-06-03 01:11:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 02:45:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496452213102260,
"parent_rev": "9bf4343a0f6521c0c9f911a68c9f65f53d60da5f", "commit_rev":
"605a5cc49fc1e9af1401c48bed56e3f3ece9f2c4"}

[commit-bot: I haz the power, 2017-06-03 02:45:36]

Description was changed from

==========
Add path validation error expectations for PKITS tests.

Also removes some duplication around expected-to-fail PKITS tests.
==========

to

==========
Add path validation error expectations for PKITS tests.

Also removes some duplication around expected-to-fail PKITS tests.

Review-Url: https://codereview.chromium.org/2918913002
Cr-Commit-Position: refs/heads/master@{#476872}
Committed:
https://chromium.googlesource.com/chromium/src/+/605a5cc49fc1e9af1401c48bed56...
==========

[commit-bot: I haz the power, 2017-06-03 02:45:38]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/605a5cc49fc1e9af1401c48bed56...