Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: net/cert/internal/parse_certificate_unittest.cc

Issue 2918913002: Add path validation error expectations for PKITS tests. (Closed)
Patch Set: Address Matt's comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/nist_pkits_unittest.cc ('k') | net/cert/internal/parsed_certificate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_certificate_unittest.cc
diff --git a/net/cert/internal/parse_certificate_unittest.cc b/net/cert/internal/parse_certificate_unittest.cc
index 6ddc768f68fbf31b2305cf5f2d421b9073775f25..303d27be9f657ce4f7d8b8babe0cfca4cd1d9230 100644
--- a/net/cert/internal/parse_certificate_unittest.cc
+++ b/net/cert/internal/parse_certificate_unittest.cc
@@ -62,8 +62,7 @@ void RunCertificateTest(const std::string& file_name) {
&signature_algorithm_tlv, &signature_value, &errors);
EXPECT_EQ(expected_result, actual_result);
- EXPECT_EQ(expected_errors, errors.ToDebugString()) << "Test file: "
- << test_file_path;
+ VerifyCertErrors(expected_errors, errors, test_file_path);
// Ensure that the parsed certificate matches expectations.
if (expected_result && actual_result) {
@@ -166,8 +165,7 @@ void RunTbsCertificateTestGivenVersion(const std::string& file_name,
ParseTbsCertificate(der::Input(&data), {}, &parsed, &errors);
EXPECT_EQ(expected_result, actual_result);
- EXPECT_EQ(expected_errors, errors.ToDebugString()) << "Test file: "
- << test_file_path;
+ VerifyCertErrors(expected_errors, errors, test_file_path);
if (!expected_result || !actual_result)
return;
« no previous file with comments | « net/cert/internal/nist_pkits_unittest.cc ('k') | net/cert/internal/parsed_certificate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698