Add path validation error expectations for PKITS tests.

net/cert/internal/test_helpers.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/test_helpers.h"
 
 #include "base/base64.h"
 #include "base/base_paths.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
@@ skipping 290 matching lines @@
   // Read the full contents of the file.
   std::string file_data;
   if (!base::ReadFileToString(filepath, &file_data)) {
     ADD_FAILURE() << "Couldn't read file: " << filepath.value();
     return std::string();
   }
 
   return file_data;
 }
 
+void VerifyCertPathErrors(const std::string& expected_errors,

[mattm, 2017/06/02 21:09:07]

maybe name this expected_errors_str to match actual_errors_str?

[eroman, 2017/06/02 23:16:17]

Done.

+                          const CertPathErrors& actual_errors,
+                          const ParsedCertificateList& chain,
+                          const std::string& errors_file_path) {
+  std::string actual_errors_str = actual_errors.ToDebugString(chain);
+  bool matches = expected_errors == actual_errors_str;
+
+  if (!matches) {

[mattm, 2017/06/02 21:09:07]

optional: dunno if using the separate |matches| variable helps, maybe just do
"if (expected_errors != actual_errors_str)"?

[eroman, 2017/06/02 23:16:17]

Done.

+    ADD_FAILURE() << "Cert path errors don't match expectations ("
+                  << errors_file_path << ")\n\n"
+                  << "EXPECTED:\n\n"
+                  << expected_errors << "\n"
+                  << "ACTUAL:\n\n"
+                  << actual_errors_str << "\n"
+                  << "===> Use "
+                     "net/data/verify_certificate_chain_unittest/"
+                     "rebase-errors.py to rebaseline.\n";
+  }
+}
+
+void VerifyCertErrors(const std::string& expected_errors,
+                      const CertErrors& actual_errors,
+                      const std::string& errors_file_path) {
+  std::string actual_errors_str = actual_errors.ToDebugString();
+  bool matches = expected_errors == actual_errors_str;
+
+  if (!matches) {
+    ADD_FAILURE() << "Cert errors don't match expectations ("
+                  << errors_file_path << ")\n\n"
+                  << "EXPECTED:\n\n"
+                  << expected_errors << "\n"
+                  << "ACTUAL:\n\n"
+                  << actual_errors_str << "\n"
+                  << "===> Use "
+                     "net/data/parse_certificate_unittest/"
+                     "rebase-errors.py to rebaseline.\n";
+  }
+}
+
 }  // namespace net