Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

BUG=672263
Review-Url: https://codereview.chromium.org/2915833003
Cr-Commit-Position: refs/heads/master@{#476038}
Committed: https://chromium.googlesource.com/chromium/src/+/970e550e6374fa36dd2d475f0692f408849c0ce6

[Ryan Hansberry, 2017-05-31 18:08:16]

Description was changed from

==========
Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

BUG=672263
==========

to

==========
Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

BUG=672263
==========

[Ryan Hansberry, 2017-05-31 18:08:17]

hansberry@chromium.org changed reviewers:
+ khorimoto@chromium.org

[khorimoto, 2017-05-31 18:13:27]

khorimoto@google.com changed reviewers:
+ khorimoto@google.com

[khorimoto, 2017-05-31 18:13:28]

lgtm

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/ble_connection_manager_unittest.cc (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/ble_connection_manager_unittest.cc:233: class
MockTimerFactory : public TimerFactory {
Move to anonymous namespace.

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/fake_ble_connection_manager.cc (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/fake_ble_connection_manager.cc:7: #include
"chromeos/components/tether/timer_factory.h"
nit: Is this needed?

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/host_scan_cache_unittest.cc (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/host_scan_cache_unittest.cc:82: class
TestTimerFactory : public TimerFactory {
Move to anonymous namespace.

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/timer_factory.h (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/timer_factory.h:18: class TimerFactory {
Add description, noting that this is used for dependency injection to inject
fake timers into tests.

[Ryan Hansberry, 2017-05-31 18:24:54]

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/ble_connection_manager_unittest.cc (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/ble_connection_manager_unittest.cc:233: class
MockTimerFactory : public TimerFactory {
On 2017/05/31 18:13:28, khorimoto wrote:
> Move to anonymous namespace.

Done.

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/fake_ble_connection_manager.cc (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/fake_ble_connection_manager.cc:7: #include
"chromeos/components/tether/timer_factory.h"
On 2017/05/31 18:13:28, khorimoto wrote:
> nit: Is this needed?

Unfortunately yes, C++ complains that TimerFactory is an incomplete class when
nullptr is passed to its super constructor (line 26 of this file).

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/host_scan_cache_unittest.cc (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/host_scan_cache_unittest.cc:82: class
TestTimerFactory : public TimerFactory {
On 2017/05/31 18:13:28, khorimoto wrote:
> Move to anonymous namespace.

Done.

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
File chromeos/components/tether/timer_factory.h (right):

https://codereview.chromium.org/2915833003/diff/20001/chromeos/components/tet...
chromeos/components/tether/timer_factory.h:18: class TimerFactory {
On 2017/05/31 18:13:28, khorimoto wrote:
> Add description, noting that this is used for dependency injection to inject
> fake timers into tests.

Done.

[Ryan Hansberry, 2017-05-31 18:25:45]

hansberry@chromium.org changed reviewers:
- khorimoto@google.com

[Kyle Horimoto, 2017-05-31 18:26:35]

LGTM (from the correct account this time!)

[Ryan Hansberry, 2017-05-31 18:28:15]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2017-05-31 18:28:16]

The patchset sent to the CQ was uploaded after l-g-t-m from khorimoto@google.com
Link to the patchset: https://codereview.chromium.org/2915833003/#ps40001
(title: "khorimoto@ comments.")

[commit-bot: I haz the power, 2017-05-31 18:28:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 19:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 19:14:25]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Kyle Horimoto, 2017-05-31 19:15:42]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-05-31 19:16:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hansberry, 2017-05-31 21:21:38]

The CQ bit was unchecked by hansberry@chromium.org

[Ryan Hansberry, 2017-05-31 21:21:45]

The CQ bit was checked by hansberry@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:23:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:36:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496265705621210,
"parent_rev": "47e4edd4527e1764c7a242ea4a6344f57a48f905", "commit_rev":
"15d7d6ce5efcb0aabaaee4cf06e1a9424ea29593"}

[commit-bot: I haz the power, 2017-05-31 21:36:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496265705621210,
"parent_rev": "c5114e9e40ecac4cfb500301ad03357b96c0966d", "commit_rev":
"970e550e6374fa36dd2d475f0692f408849c0ce6"}

[commit-bot: I haz the power, 2017-05-31 21:36:30]

Description was changed from

==========
Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

BUG=672263
==========

to

==========
Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

BUG=672263

Review-Url: https://codereview.chromium.org/2915833003
Cr-Commit-Position: refs/heads/master@{#476038}
Committed:
https://chromium.googlesource.com/chromium/src/+/970e550e6374fa36dd2d475f0692...
==========

[commit-bot: I haz the power, 2017-05-31 21:36:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/970e550e6374fa36dd2d475f0692...