chromeos/components/tether/fake_ble_connection_manager.cc - Issue 2915833003: Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/components/tether/fake_ble_connection_manager.cc

Issue 2915833003: Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache. (Closed)

Patch Set: Add missing files. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromeos/components/tether/ble_connection_manager_unittest.cc ('K') | « chromeos/components/tether/ble_connection_manager_unittest.cc ('k') | chromeos/components/tether/host_scan_cache.h » ('j') | chromeos/components/tether/host_scan_cache_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chromeos/components/tether/fake_ble_connection_manager.h"	5 #include "chromeos/components/tether/fake_ble_connection_manager.h"

6	6

	7 #include "chromeos/components/tether/timer_factory.h"
	khorimoto 2017/05/31 18:13:28 nit: Is this needed? nit: Is this needed? Ryan Hansberry 2017/05/31 18:24:54 Unfortunately yes, C++ complains that TimerFactory Show quoted text On 2017/05/31 18:13:28, khorimoto wrote: > nit: Is this needed? Unfortunately yes, C++ complains that TimerFactory is an incomplete class when nullptr is passed to its super constructor (line 26 of this file).
	8

7 namespace chromeos {	9 namespace chromeos {

8	10

9 namespace tether {	11 namespace tether {

10	12

11 FakeBleConnectionManager::StatusAndRegisteredMessageTypes::	13 FakeBleConnectionManager::StatusAndRegisteredMessageTypes::

12 StatusAndRegisteredMessageTypes()	14 StatusAndRegisteredMessageTypes()

13 : status(cryptauth::SecureChannel::Status::DISCONNECTED) {}	15 : status(cryptauth::SecureChannel::Status::DISCONNECTED) {}

14	16

15 FakeBleConnectionManager::StatusAndRegisteredMessageTypes::	17 FakeBleConnectionManager::StatusAndRegisteredMessageTypes::

16 StatusAndRegisteredMessageTypes(	18 StatusAndRegisteredMessageTypes(

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86 return false;	88 return false;

87 }	89 }

88	90

89 *status = iter->second.status;	91 *status = iter->second.status;

90 return true;	92 return true;

91 }	93 }

92	94

93 } // namespace tether	95 } // namespace tether

94	96

95 } // namespace chromeos	97 } // namespace chromeos

OLD	NEW