Tether: Break helper TimerFactory out of BleConnectionManager and HostScanCache.

chromeos/components/tether/host_scan_cache_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/components/tether/host_scan_cache.h"
 
 #include <memory>
 #include <unordered_map>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/memory/ptr_util.h"
 #include "base/test/scoped_task_environment.h"
 #include "base/timer/mock_timer.h"
 #include "chromeos/components/tether/device_id_tether_network_guid_map.h"
 #include "chromeos/components/tether/fake_active_host.h"
 #include "chromeos/components/tether/fake_host_scan_cache.h"
 #include "chromeos/components/tether/mock_tether_host_response_recorder.h"
+#include "chromeos/components/tether/timer_factory.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
 #include "chromeos/network/network_state_test.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::NiceMock;
 using testing::Invoke;
 
@@ skipping 34 matching lines @@
   explicit ExtendedMockTimer(const base::Closure& destructor_callback)
       : base::MockTimer(true /* retain_user_task */, false /* is_repeating */),
         destructor_callback_(destructor_callback) {}
 
   ~ExtendedMockTimer() override { destructor_callback_.Run(); }
 
  private:
   base::Closure destructor_callback_;
 };
 
+class TestTimerFactory : public TimerFactory {
+ public:
+  TestTimerFactory() {}
+  ~TestTimerFactory() override {}
+
+  std::unordered_map<std::string, ExtendedMockTimer*>&
+  tether_network_guid_to_timer_map() {
+    return tether_network_guid_to_timer_map_;
+  }
+
+  void set_tether_network_guid_for_next_timer(
+      const std::string& tether_network_guid_for_next_timer) {
+    tether_network_guid_for_next_timer_ = tether_network_guid_for_next_timer;
+  }
+
+  // TimerFactory:
+  std::unique_ptr<base::Timer> CreateOneShotTimer() override {
+    EXPECT_FALSE(tether_network_guid_for_next_timer_.empty());
+    ExtendedMockTimer* mock_timer = new ExtendedMockTimer(base::Bind(
+        &TestTimerFactory::OnActiveTimerDestructor, base::Unretained(this),
+        tether_network_guid_for_next_timer_));
+    tether_network_guid_to_timer_map_[tether_network_guid_for_next_timer_] =
+        mock_timer;
+    return base::WrapUnique(mock_timer);
+  }
+
+ private:
+  void OnActiveTimerDestructor(const std::string& tether_network_guid) {
+    tether_network_guid_to_timer_map_.erase(
+        tether_network_guid_to_timer_map_.find(tether_network_guid));
+  }
+
+  std::string tether_network_guid_for_next_timer_;
+  std::unordered_map<std::string, ExtendedMockTimer*>
+      tether_network_guid_to_timer_map_;
+};
+
 }  // namespace
 
 // TODO(khorimoto): The test uses a FakeHostScanCache to keep an in-memory
 // cache of expected values. This has the potential to be confusing, since this
 // is the test for HostScanCache. Clean this up to avoid using FakeHostScanCache
 // if possible.
 class HostScanCacheTest : public NetworkStateTest {
  protected:
-  class TestTimerFactory : public HostScanCache::TimerFactory {
-   public:
-    TestTimerFactory() {}
-    ~TestTimerFactory() {}
-
-    std::unordered_map<std::string, ExtendedMockTimer*>&
-    tether_network_guid_to_timer_map() {
-      return tether_network_guid_to_timer_map_;
-    }
-
-    void set_tether_network_guid_for_next_timer(
-        const std::string& tether_network_guid_for_next_timer) {
-      tether_network_guid_for_next_timer_ = tether_network_guid_for_next_timer;
-    }
-
-    // HostScanCache::TimerFactory:
-    std::unique_ptr<base::Timer> CreateOneShotTimer() override {
-      EXPECT_FALSE(tether_network_guid_for_next_timer_.empty());
-      ExtendedMockTimer* mock_timer = new ExtendedMockTimer(base::Bind(
-          &TestTimerFactory::OnActiveTimerDestructor, base::Unretained(this),
-          tether_network_guid_for_next_timer_));
-      tether_network_guid_to_timer_map_[tether_network_guid_for_next_timer_] =
-          mock_timer;
-      return base::WrapUnique(mock_timer);
-    }
-
-   private:
-    void OnActiveTimerDestructor(const std::string& tether_network_guid) {
-      tether_network_guid_to_timer_map_.erase(
-          tether_network_guid_to_timer_map_.find(tether_network_guid));
-    }
-
-    std::string tether_network_guid_for_next_timer_;
-    std::unordered_map<std::string, ExtendedMockTimer*>
-        tether_network_guid_to_timer_map_;
-  };
-
   HostScanCacheTest() {}
 
   void SetUp() override {
     DBusThreadManager::Initialize();
     NetworkStateTest::SetUp();
     network_state_handler()->SetTetherTechnologyState(
         NetworkStateHandler::TECHNOLOGY_ENABLED);
 
     test_timer_factory_ = new TestTimerFactory();
     fake_active_host_ = base::MakeUnique<FakeActiveHost>();
@@ skipping 310 matching lines @@
 
   // Simulate a connection to device 1.
   SetActiveHost(kTetherGuid1);
   SetHasConnectedToHost(kTetherGuid1);
   VerifyCacheMatchesNetworkStack();
 }
 
 }  // namespace tether
 
 }  // namespace chromeos