Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(66)

Issue 2915773002: Reland of [css-align] Don't resolve 'auto' values for computed style. (Closed)

Created:
3 years, 9 months ago by jfernandez
Modified:
3 years, 9 months ago
CC:
cbiesinger, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, rwlbuis, svillar, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [css-align] Don't resolve 'auto' values for computed style. Fixed the regression caused by the previous patch and provided a proper regression test. Reason for revert: This patch breaks DevTools toolbars (Console gear icon, checkbox labels are centered), it also seems to break the Welcome to Chrome page layout. Original issue's description: > [css-align] Don't resolve 'auto' values for computed style. > > The CSS Box Alignment specification has been changed recently so that > now all the propeties have the specificed value as computed value. The > rationale of this change are at the associated W3C github issue [1]. > > This change implies that we don't need to execute the StyleAdjuter > logic we implemented specifically for supporting 'auto' values > resolution for computed style. We can live now with resolution at > layout time only. > > [1] https://github.com/w3c/csswg-drafts/issues/440 > > BUG=725489 > > Review-Url: https://codereview.chromium.org/2455093002 > Cr-Commit-Position: refs/heads/master@{#475400} > Committed: https://chromium.googlesource.com/chromium/src/+/5389373c6dec30d783eb46b4c8190720f411a8a7 TBR=cbiesinger@chromium.org,cbiesinger@google.com,meade@chromium.org,rego@igalia.com,svillar@igalia.com,jfernandez@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725489 Review-Url: https://codereview.chromium.org/2913093002 Cr-Commit-Position: refs/heads/master@{#475689} Committed: https://chromium.googlesource.com/chromium/src/+/8e4d09ab6b864897d8399ccda555a61b030ceb84 BUG=725489 Review-Url: https://codereview.chromium.org/2915773002 Cr-Commit-Position: refs/heads/master@{#476024} Committed: https://chromium.googlesource.com/chromium/src/+/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3

Patch Set 1 #

Total comments: 6

Patch Set 2 : Applied suggested changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -283 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/css-properties.html View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/css/css-align-3/default-alignment/place-items-shorthand-006.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html View 1 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes-expected.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/ensure-flexbox-compatibility-with-initial-values-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/new-alignment-values-invalid-if-grid-not-enabled.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html View 8 chunks +24 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements.html View 16 chunks +27 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html View 8 chunks +24 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html View 3 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-place-self.html View 5 chunks +33 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 3 chunks +8 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 2 chunks +18 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 5 chunks +72 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jfernandez
PTAL
3 years, 9 months ago (2017-05-31 13:06:32 UTC) #1
jfernandez
@cbiesinger could you please take a look at the WPT test as well ?
3 years, 9 months ago (2017-05-31 13:08:36 UTC) #2
cbiesinger
I can look in a bit -- in the meantime, can you describe what caused ...
3 years, 9 months ago (2017-05-31 13:18:24 UTC) #3
cbiesinger
I can look in a bit -- in the meantime, can you describe what caused ...
3 years, 9 months ago (2017-05-31 13:18:25 UTC) #4
jfernandez
Hi Christian, On 2017/05/31 13:18:25, cbiesinger wrote: > I can look in a bit -- ...
3 years, 9 months ago (2017-05-31 14:31:30 UTC) #5
jfernandez
BTW, this is the regression test I added in this CL: external/wpt/css/css-flexbox-1/align-items-006.html
3 years, 9 months ago (2017-05-31 14:32:25 UTC) #6
cbiesinger
lgtm w/ comment below, assuming that the LayoutBox change & new test is the only ...
3 years, 9 months ago (2017-05-31 18:59:51 UTC) #7
jfernandez
https://codereview.chromium.org/2915773002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html File third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html (right): https://codereview.chromium.org/2915773002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html#newcode7 third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html:7: <link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#propdef-align-items" /> On 2017/05/31 18:59:51, cbiesinger wrote: ...
3 years, 9 months ago (2017-05-31 21:03:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915773002/20001
3 years, 9 months ago (2017-05-31 21:11:51 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-05-31 21:13:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d10fc6ad638e7cd58576fd378ee4...

Powered by Google App Engine
This is Rietveld 408576698