Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 2913093002: Revert of [css-align] Don't resolve 'auto' values for computed style. (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, cbiesinger, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, svillar, szager+layoutwatch_chromium.org, zoltan1, jeffcarp
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [css-align] Don't resolve 'auto' values for computed style. (patchset #12 id:210001 of https://codereview.chromium.org/2455093002/ ) Reason for revert: This patch breaks DevTools toolbars (Console gear icon, checkbox labels are centered), it also seems to break the Welcome to Chrome page layout. Original issue's description: > [css-align] Don't resolve 'auto' values for computed style. > > The CSS Box Alignment specification has been changed recently so that > now all the propeties have the specificed value as computed value. The > rationale of this change are at the associated W3C github issue [1]. > > This change implies that we don't need to execute the StyleAdjuter > logic we implemented specifically for supporting 'auto' values > resolution for computed style. We can live now with resolution at > layout time only. > > [1] https://github.com/w3c/csswg-drafts/issues/440 > > BUG=725489 > > Review-Url: https://codereview.chromium.org/2455093002 > Cr-Commit-Position: refs/heads/master@{#475400} > Committed: https://chromium.googlesource.com/chromium/src/+/5389373c6dec30d783eb46b4c8190720f411a8a7 TBR=cbiesinger@chromium.org,cbiesinger@google.com,meade@chromium.org,rego@igalia.com,svillar@igalia.com,jfernandez@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725489 Review-Url: https://codereview.chromium.org/2913093002 Cr-Commit-Position: refs/heads/master@{#475689} Committed: https://chromium.googlesource.com/chromium/src/+/8e4d09ab6b864897d8399ccda555a61b030ceb84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -306 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/css-properties.html View 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt View 2 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/css/css-align-3/default-alignment/place-items-shorthand-006.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes-expected.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/ensure-flexbox-compatibility-with-initial-values-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/new-alignment-values-invalid-if-grid-not-enabled.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html View 8 chunks +11 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements.html View 16 chunks +27 lines, -27 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements-expected.txt View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html View 8 chunks +11 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html View 3 chunks +12 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-place-self.html View 5 chunks +29 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 3 chunks +33 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 2 chunks +2 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 5 chunks +29 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
pfeldman
Created Revert of [css-align] Don't resolve 'auto' values for computed style.
3 years, 9 months ago (2017-05-30 23:30:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913093002/1
3 years, 9 months ago (2017-05-30 23:31:35 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-05-30 23:32:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e4d09ab6b864897d8399ccda555...

Powered by Google App Engine
This is Rietveld 408576698