third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html - Issue 2915773002: Reland of [css-align] Don't resolve 'auto' values for computed style.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html

Issue 2915773002: Reland of [css-align] Don't resolve 'auto' values for computed style. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/css/css-align-3/default-alignment/place-items-shorthand-006.html ('k') | third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html PUBLIC "-//W3C//DTD//XHTML 1.0 Strict//EN" "http://www.w3.org/TR/ xhtml1/DTD/xhtml1-strict.dtd">

	2 <html xmlns="http://www.w3.org/1999/xhtml">

	3 <head>

	4 <title>CSS Test: A flex container with 'column' direction and 'align-ite ms' property set to 'flex-start'</title>

	5 <link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:j fernandez@igalia.com">

	6 <link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#align-items-p roperty" />

	7 <link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#propdef-align -items" />
	cbiesinger 2017/05/31 18:59:51 Per https://github.com/w3c/web-platform-tests/pull Per https://github.com/w3c/web-platform-tests/pull/6071 this should not be used; instead, use align-items-property. And since you already have a line for that one you can remove this line. jfernandez 2017/05/31 21:03:43 Done. Show quoted text On 2017/05/31 18:59:51, cbiesinger wrote: > Per https://github.com/w3c/web-platform-tests/pull/6071 this should not be used; > instead, use align-items-property. And since you already have a line for that > one you can remove this line. Done.
	8 <link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#flex-directio n-property" />

	9 <link rel="match" href="reference/align-content-001-ref.html" />

	10 <meta name="assert" content="This test checks that 'align-items: flex-st art' implies the flex item's 'auto' width to be resolved as 'fit-content'." />

	11 <style type="text/css">

	12 .block {

	13 position: absolute;

	14 width: 300px;

	15 height: 100px;

	16 }

	17 #flexbox

	18 {

	19 z-index: -1;
	cbiesinger 2017/05/31 18:59:51 This has no effect since the flexbox is not positi This has no effect since the flexbox is not positioned. It's also not necessary... just remove this line. jfernandez 2017/05/31 21:03:43 Done. Show quoted text On 2017/05/31 18:59:51, cbiesinger wrote: > This has no effect since the flexbox is not positioned. It's also not > necessary... just remove this line. Done.
	20 font: 50px/1 Ahem;

	21 background: green;

	22 flex-direction: column;

	23 align-items: flex-start;

	24 display: flex;

	25 width: 300px;

	26 height: 100px;

	27 }

	28 .block > div

	29 {

	30 background: green;

	31 width: 200px;

	32 height: 50px;

	33 }

	34 #flexbox > div

	35 {

	36 background: red;

	37 color: red;

	38 }

	39 </style>

	40 </head>

	41 <body>

	42 <p>Test passes if there is no red visible on the page.</p>

	43 <div class="block">

	44 <div style="top: 0px; left: 0px;"></div>
	cbiesinger 2017/05/31 18:59:51 This div is not positioned, right? Why give it a t This div is not positioned, right? Why give it a top and left property? jfernandez 2017/05/31 21:03:43 Done. Show quoted text On 2017/05/31 18:59:51, cbiesinger wrote: > This div is not positioned, right? Why give it a top and left property? Done.
	45 </div>

	46 <div id="flexbox">

	47 <div>XXXX</div>

	48 </div>

	49 </body>

	50 </html>

OLD	NEW