Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2915143002: VR: Soften the floor grid (Closed)

Created:
3 years, 6 months ago by acondor_
Modified:
3 years, 6 months ago
Reviewers:
mthiesse
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Soften the floor grid - The grid is now drawn in the fragment shader instead of calling DrawLines. - A single quad is used for the floor, mixing the background and the grid itself in a single shader. - The geometry simplifies from a set of lines to a single quad. - The precision for gradient shaders was set to low to reduce stress in the GPU. BUG=728146 Presubmit doesn't like float casts in the shader code, which it thinks is c++ when it isn't. NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2907203002 Cr-Original-Commit-Position: refs/heads/master@{#475935} Review-Url: https://codereview.chromium.org/2915143002 Cr-Commit-Position: refs/branch-heads/3112@{#98} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2cf486993e67211dd0a470bd86f4c3eec1234df4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -91 lines) Patch
M chrome/browser/android/vr_shell/ui_elements/ui_element.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 4 chunks +3 lines, -19 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.cc View 3 chunks +47 lines, -58 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
acondor_
PTAL
3 years, 6 months ago (2017-06-01 18:03:04 UTC) #2
mthiesse
lgtm
3 years, 6 months ago (2017-06-01 18:03:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915143002/1
3 years, 6 months ago (2017-06-01 18:04:06 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-01 18:04:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915143002/1
3 years, 6 months ago (2017-06-01 18:06:45 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 18:07:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cf486993e67211dd0a470bd86f4...

Powered by Google App Engine
This is Rietveld 408576698