VR: Soften the floor grid

VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
# Presubmit doesn't like float casts in the shader code, which it thinks is c++ when it isn't.
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2907203002
Cr-Commit-Position: refs/heads/master@{#475935}
Committed: https://chromium.googlesource.com/chromium/src/+/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e

[acondor_, 2017-05-29 21:17:11]

Description was changed from

==========
VR: A softer grid

- The grid is now drawn in the fragment shader instead of calling DrawLines
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=
==========

to

==========
VR: A softer grid

- The grid is now drawn in the fragment shader instead of calling DrawLines
- The precision for gradient shaders was set to low to reduce stress in the GPU.
- A single quad is used for the floor.

BUG=
==========

[acondor_, 2017-05-31 14:21:18]

Description was changed from

==========
VR: A softer grid

- The grid is now drawn in the fragment shader instead of calling DrawLines
- The precision for gradient shaders was set to low to reduce stress in the GPU.
- A single quad is used for the floor.

BUG=
==========

to

==========
VR: A softer grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
==========

[acondor_, 2017-05-31 14:21:37]

acondor@google.com changed reviewers:
+ mthiesse@chromium.org

[acondor_, 2017-05-31 14:21:37]

PTAL

[acondor_, 2017-05-31 14:22:34]

acondor@google.com changed reviewers:
+ cjgrant@chromium.org

[acondor_, 2017-05-31 14:22:35]

PTAL

[mthiesse, 2017-05-31 14:36:39]

Description was changed from

==========
VR: A softer grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
==========

to

==========
VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
==========

[mthiesse, 2017-05-31 14:41:02]

lgtm % nits

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell_renderer.cc (right):

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell_renderer.cc:267: float diff = diff_x <
diff_y ? diff_x : diff_y;
nit: use min?

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell_renderer.cc:272: gl_FragColor =
vec4(grid_color.xyz + bg_color.xyz * (1.0 - opacity),
nit: line length

[cjgrant, 2017-05-31 14:49:17]

lgtm

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (left):

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:255:
element->set_debug_id(kFloorGrid);
Need to remove kFloorGrid from the debug enum and tests.

[acondor_, 2017-05-31 15:38:31]

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (left):

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:255:
element->set_debug_id(kFloorGrid);
On 2017/05/31 14:49:17, cjgrant wrote:
> Need to remove kFloorGrid from the debug enum and tests.

Done.

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell_renderer.cc (right):

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell_renderer.cc:267: float diff = diff_x <
diff_y ? diff_x : diff_y;
On 2017/05/31 14:41:01, mthiesse wrote:
> nit: use min?

Done.

https://codereview.chromium.org/2907203002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell_renderer.cc:272: gl_FragColor =
vec4(grid_color.xyz + bg_color.xyz * (1.0 - opacity),
On 2017/05/31 14:41:01, mthiesse wrote:
> nit: line length

Done.

[acondor_, 2017-05-31 15:38:36]

The CQ bit was checked by acondor@google.com

[acondor_, 2017-05-31 15:38:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2907203002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2017-05-31 15:39:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 15:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 15:47:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[acondor_, 2017-05-31 16:00:49]

Description was changed from

==========
VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
==========

to

==========
VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
NOPRESUBMIT=true
==========

[acondor_, 2017-05-31 16:00:57]

The CQ bit was checked by acondor@google.com

[commit-bot: I haz the power, 2017-05-31 16:01:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2017-05-31 16:09:37]

Description was changed from

==========
VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
NOPRESUBMIT=true
==========

to

==========
VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
# Presubmit doesn't like float casts in the shader code, which it thinks is c++
when it isn't.
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2017-05-31 16:23:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496246457950180,
"parent_rev": "984c0003a871be8eec92691961ae0617fe728fb1", "commit_rev":
"5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e"}

[commit-bot: I haz the power, 2017-05-31 16:23:23]

Description was changed from

==========
VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
# Presubmit doesn't like float casts in the shader code, which it thinks is c++
when it isn't.
NOPRESUBMIT=true
==========

to

==========
VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself
in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG=728146
# Presubmit doesn't like float casts in the shader code, which it thinks is c++
when it isn't.
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2907203002
Cr-Commit-Position: refs/heads/master@{#475935}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d5052f3e33d06bf1f6710a8e1a9...
==========

[commit-bot: I haz the power, 2017-05-31 16:23:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5d5052f3e33d06bf1f6710a8e1a9...