Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2951)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_manager.cc

Issue 2915143002: VR: Soften the floor grid (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_scene_manager.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager.cc b/chrome/browser/android/vr_shell/ui_scene_manager.cc
index 8fce01c4e8ba77db9f4b917b042ec0458be18b39..0b702e74c7730c1813eb335b22bf6cef5f21fa0e 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager.cc
@@ -230,8 +230,9 @@ void UiSceneManager::CreateBackground() {
element->set_size({kSceneSize, kSceneSize, 1.0});
element->set_translation({0.0, -kSceneHeight / 2, 0.0});
element->set_rotation({1.0, 0.0, 0.0, -M_PI / 2.0});
- element->set_fill(vr_shell::Fill::OPAQUE_GRADIENT);
+ element->set_fill(vr_shell::Fill::GRID_GRADIENT);
element->set_draw_phase(0);
+ element->set_gridline_count(kFloorGridlineCount);
floor_ = element.get();
content_elements_.push_back(element.get());
scene_->AddUiElement(std::move(element));
@@ -240,7 +241,6 @@ void UiSceneManager::CreateBackground() {
element = base::MakeUnique<UiElement>();
element->set_debug_id(kCeiling);
element->set_id(AllocateId());
- element->set_fill(vr_shell::Fill::OPAQUE_GRADIENT);
element->set_size({kSceneSize, kSceneSize, 1.0});
element->set_translation({0.0, kSceneHeight / 2, 0.0});
element->set_rotation({1.0, 0.0, 0.0, M_PI / 2});
@@ -250,20 +250,6 @@ void UiSceneManager::CreateBackground() {
content_elements_.push_back(element.get());
scene_->AddUiElement(std::move(element));
- // Floor grid.
- element = base::MakeUnique<UiElement>();
- element->set_debug_id(kFloorGrid);
- element->set_id(AllocateId());
- element->set_size({kSceneSize, kSceneSize, 1.0});
- element->set_translation({0.0, -kSceneHeight / 2 + kTextureOffset, 0.0});
- element->set_rotation({1.0, 0.0, 0.0, -M_PI / 2});
- element->set_fill(vr_shell::Fill::GRID_GRADIENT);
- element->set_gridline_count(kFloorGridlineCount);
- element->set_draw_phase(0);
- floor_grid_ = element.get();
- content_elements_.push_back(element.get());
- scene_->AddUiElement(std::move(element));
-
UpdateBackgroundColor();
}
@@ -362,9 +348,7 @@ void UiSceneManager::UpdateBackgroundColor() {
ceiling_->set_edge_color(color_scheme().horizon);
floor_->set_center_color(color_scheme().floor);
floor_->set_edge_color(color_scheme().horizon);
- floor_grid_->set_center_color(color_scheme().floor_grid);
- SkColor floor_grid_edge_color = SkColorSetA(color_scheme().floor_grid, 0);
- floor_grid_->set_edge_color(floor_grid_edge_color);
+ floor_->set_grid_color(color_scheme().floor_grid);
}
void UiSceneManager::SetAudioCapturingIndicator(bool enabled) {
« no previous file with comments | « chrome/browser/android/vr_shell/ui_scene_manager.h ('k') | chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698