Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2915123002: Improve position information. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M pkg/front_end/lib/src/fasta/builder/prefix_builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +18 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 9 chunks +16 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/quote.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (3 generated)
ahe
3 years, 6 months ago (2017-06-01 17:44:55 UTC) #3
Paul Berry
lgtm
3 years, 6 months ago (2017-06-01 18:29:54 UTC) #4
ahe
3 years, 6 months ago (2017-06-02 13:15:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
a79a59d19c7cf3261fdf2760b22915e80a899564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698