Improve position information.

pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.fasta_accessors;
 
 import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart'
     show KernelArguments;
 
 import 'package:front_end/src/fasta/kernel/utils.dart' show offsetForToken;
@@ skipping 129 matching lines @@
 
   Expression makeInvalidWrite(Expression value) {
     return buildThrowNoSuchMethodError(new KernelArguments(<Expression>[value]),
         isSetter: true);
   }
 
   /* Expression | FastaAccessor | Initializer */ doInvocation(
       int offset, Arguments arguments);
 
   /* Expression | FastaAccessor */ buildPropertyAccess(
-      IncompleteSend send, bool isNullAware) {
+      IncompleteSend send, int operatorOffset, bool isNullAware) {
     if (send is SendAccessor) {
       return helper.buildMethodInvocation(buildSimpleRead(), send.name,
           send.arguments, offsetForToken(send.token),
           isNullAware: isNullAware);
     } else {
       if (helper.constantExpressionRequired && send.name != lengthName) {
         helper.addCompileTimeError(
             offsetForToken(token), "Not a constant expression.");
       }
       return PropertyAccessor.make(helper, send.token, buildSimpleRead(),
@@ skipping 21 matching lines @@
   /// most one of [isGetter] and [isSetter] should be true and they're passed
   /// to [BuilderHelper.buildThrowNoSuchMethodError] if it is used.
   Expression buildError(Arguments arguments,
       {bool isGetter: false, bool isSetter: false, int offset});
 
   Name get name => internalError("Unsupported operation.");
 
   @override
   String get plainNameForRead => name.name;
 
-  withReceiver(Object receiver, {bool isNullAware}) => this;
+  withReceiver(Object receiver, int operatorOffset, {bool isNullAware}) => this;
 
   @override
   Initializer buildFieldInitializer(
       Map<String, FieldInitializer> initializers) {
     return helper.buildInvalidIntializer(
         buildError(new Arguments.empty(), isSetter: true));
   }
 
   @override
   doInvocation(int offset, Arguments arguments) {
     return buildError(arguments, offset: offset);
   }
 
   @override
-  buildPropertyAccess(IncompleteSend send, bool isNullAware) => this;
+  buildPropertyAccess(
+      IncompleteSend send, int operatorOffset, bool isNullAware) {
+    return this;
+  }
 
   @override
   buildThrowNoSuchMethodError(Arguments arguments,
       {bool isSuper: false,
       isGetter: false,
       isSetter: false,
       String name,
       int offset}) {
     return this;
   }
@@ skipping 75 matching lines @@
   Initializer buildFieldInitializer(
       Map<String, FieldInitializer> initializers) {
     String keyword = isSuper ? "super" : "this";
     int offset = offsetForToken(token);
     return helper.buildInvalidIntializer(
         helper.buildCompileTimeError(
             "Can't use '$keyword' here, did you mean '$keyword()'?", offset),
         offset);
   }
 
-  buildPropertyAccess(IncompleteSend send, bool isNullAware) {
+  buildPropertyAccess(
+      IncompleteSend send, int operatorOffset, bool isNullAware) {
     if (isInitializer && send is SendAccessor) {
       return buildConstructorInitializer(
           offsetForToken(send.token), send.name, send.arguments);
     }
     if (send is SendAccessor) {
       // Notice that 'this' or 'super' can't be null. So we can ignore the
       // value of [isNullAware].
       MethodInvocation result = helper.buildMethodInvocation(
           new ThisExpression(),
           send.name,
@@ skipping 84 matching lines @@
 abstract class IncompleteSend extends FastaAccessor {
   final BuilderHelper helper;
 
   @override
   final Token token;
 
   final Name name;
 
   IncompleteSend(this.helper, this.token, this.name);
 
-  withReceiver(Object receiver, {bool isNullAware});
+  withReceiver(Object receiver, int operatorOffset, {bool isNullAware});
 
   Arguments get arguments => null;
 }
 
 class IncompleteError extends IncompleteSend with ErrorAccessor {
   final Object error;
 
   IncompleteError(BuilderHelper helper, Token token, this.error)
       : super(helper, token, null);
 
@@ skipping 20 matching lines @@
   String get plainNameForRead => name.name;
 
   Expression buildSimpleRead() {
     return internalError("Unhandled");
   }
 
   Expression buildAssignment(Expression value, {bool voidContext: false}) {
     return internalError("Unhandled");
   }
 
-  withReceiver(Object receiver, {bool isNullAware: false}) {
+  withReceiver(Object receiver, int operatorOffset, {bool isNullAware: false}) {
     if (receiver is FastaAccessor) {
-      return receiver.buildPropertyAccess(this, isNullAware);
+      return receiver.buildPropertyAccess(this, operatorOffset, isNullAware);
     }
     if (receiver is PrefixBuilder) {
       PrefixBuilder prefix = receiver;
       receiver = helper.scopeLookup(prefix.exports, name.name, token,
           isQualified: true, prefix: prefix);
       return helper.finishSend(receiver, arguments, offsetForToken(token));
     }
     return helper.buildMethodInvocation(
         helper.toValue(receiver), name, arguments, offsetForToken(token),
         isNullAware: isNullAware);
@@ skipping 34 matching lines @@
       : super(helper, token, name);
 
   String get plainNameForRead => name.name;
 
   Expression buildSimpleRead() => internalError("Unhandled");
 
   Expression buildAssignment(Expression value, {bool voidContext: false}) {
     return internalError("Unhandled");
   }
 
-  withReceiver(Object receiver, {bool isNullAware: false}) {
+  withReceiver(Object receiver, int operatorOffset, {bool isNullAware: false}) {
     if (receiver is FastaAccessor) {
-      return receiver.buildPropertyAccess(this, isNullAware);
+      return receiver.buildPropertyAccess(this, operatorOffset, isNullAware);
     }
     if (receiver is PrefixBuilder) {
       PrefixBuilder prefix = receiver;
       return helper.scopeLookup(prefix.exports, name.name, token,
           isQualified: true, prefix: prefix);
     }
 
     return PropertyAccessor.make(
         helper, token, helper.toValue(receiver), name, null, null, isNullAware);
   }
@@ skipping 326 matching lines @@
     return super.expression;
   }
 
   Expression makeInvalidWrite(Expression value) {
     return buildThrowNoSuchMethodError(
         new Arguments(<Expression>[value])..fileOffset = value.fileOffset,
         isSetter: true);
   }
 
   @override
-  buildPropertyAccess(IncompleteSend send, bool isNullAware) {
+  buildPropertyAccess(
+      IncompleteSend send, int operatorOffset, bool isNullAware) {
     // `SomeType?.toString` is the same as `SomeType.toString`, not
     // `(SomeType).toString`.
     isNullAware = false;
 
     Name name = send.name;
     Arguments arguments = send.arguments;
 
     if (declaration is KernelClassBuilder) {
       KernelClassBuilder declaration = this.declaration;
       Builder builder = declaration.findStaticBuilder(
@@ skipping 15 matching lines @@
           setter = builder;
         }
         accessor =
             new StaticAccessor.fromBuilder(helper, builder, send.token, setter);
       }
 
       return arguments == null
           ? accessor
           : accessor.doInvocation(offsetForToken(send.token), arguments);
     } else {
-      return super.buildPropertyAccess(send, isNullAware);
+      return super.buildPropertyAccess(send, operatorOffset, isNullAware);
     }
   }
 
   DartType buildType(List<DartType> arguments,
       {bool nonInstanceAccessIsError: false}) {
     DartType type =
         declaration.buildTypesWithBuiltArguments(helper.library, arguments);
     if (type is TypeParameterType) {
       return helper.validatedTypeVariableUse(
           type, offsetForToken(token), nonInstanceAccessIsError);
@@ skipping 23 matching lines @@
       {bool isGetter: false, bool isSetter: false, int offset}) {
     return helper.throwNoSuchMethodError(
         plainNameForRead, arguments, offset ?? offsetForToken(this.token),
         isGetter: isGetter, isSetter: isSetter);
   }
 }
 
 bool isFieldOrGetter(Member member) {
   return member is Field || (member is Procedure && member.isGetter);
 }