Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2915123002: Improve position information. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index 70598467aace9f575568ef08832229764b526ae9..bd2a56981c0921ad635d678c697f7522e315d2f2 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -159,11 +159,11 @@ class OutlineBuilder extends UnhandledListener {
@override
void endPart(Token partKeyword, Token semicolon) {
debugEvent("Part");
- popCharOffset();
+ int charOffset = popCharOffset();
String uri = pop();
List<MetadataBuilder> metadata = pop();
if (uri != null) {
- library.addPart(metadata, uri);
+ library.addPart(metadata, uri, charOffset);
}
checkEmpty(partKeyword.charOffset);
}
@@ -395,7 +395,8 @@ class OutlineBuilder extends UnhandledListener {
debugEvent("MixinApplication");
List<TypeBuilder> mixins = pop();
TypeBuilder supertype = pop();
- push(library.addMixinApplication(supertype, mixins, -1));
+ push(
+ library.addMixinApplication(supertype, mixins, withKeyword.charOffset));
}
@override
« no previous file with comments | « pkg/front_end/lib/src/fasta/quote.dart ('k') | pkg/front_end/lib/src/fasta/source/source_library_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698