Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2915933004: Clean up handling of types. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with 586a465c45db7d1ec7498b8c1df9cc8d245e8e61. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -195 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 13 chunks +37 lines, -48 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 9 chunks +100 lines, -65 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart View 1 chunk +10 lines, -11 lines 0 comments Download
M tests/co19/co19-kernel.status View 7 chunks +0 lines, -21 lines 0 comments Download
M tests/language/language_kernel.status View 1 7 chunks +1 line, -37 lines 0 comments Download
M tests/lib/lib.status View 1 7 chunks +9 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 6 months ago (2017-06-01 17:02:57 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-06-01 21:49:24 UTC) #3
ahe
3 years, 6 months ago (2017-06-02 12:53:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cbcb7d4885b3a380c05140dee0fcaf8840a13558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698