Replace profile statistics preference count with AutofillCounter

Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail 
anymore.
Change 'Browsing History' to 'Browsing history' for consistency with
'Autofill form data' and other Clear Browsing Data strings.

BUG=716267
Review-Url: https://codereview.chromium.org/2915053002
Cr-Commit-Position: refs/heads/master@{#479336}
Committed: https://chromium.googlesource.com/chromium/src/+/17645964f33b591deea14589845132be05e8ad9f

[dullweber, 2017-06-01 14:30:40]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 14:31:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 15:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 15:17:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dullweber, 2017-06-01 15:59:34]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 16:00:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 17:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 17:39:49]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-06-02 09:41:49]

Patchset #3 (id:40001) has been deleted

[dullweber, 2017-06-02 09:43:45]

dullweber@chromium.org changed reviewers:
+ msarda@chromium.org

[dullweber, 2017-06-02 09:43:46]

Hi Mihai,

as a last step I'm replacing the preference count with an autofill counter.

[dullweber, 2017-06-02 09:45:28]

Description was changed from

==========
Replace profile statistics preference count with AutofillCounter

Remove ProfileStatisticsAggregator refcounting because now all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.
Cleanup

BUG=716267
==========

to

==========
Replace profile statistics preference count with AutofillCounter

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

[msarda, 2017-06-05 11:46:03]

LGTM with a suggestion.

https://codereview.chromium.org/2915053002/diff/60001/chrome/browser/profiles...
File chrome/browser/profiles/profile_statistics_common.cc (right):

https://codereview.chromium.org/2915053002/diff/60001/chrome/browser/profiles...
chrome/browser/profiles/profile_statistics_common.cc:11: const char
kProfileStatisticsAutofill[] = "Autofill";
It was not clear to me from the CL description or from the bugs why we're
changing from using Settings to Autofill in this CL as this is a product change
(I finally found this explanation in a document, but this info was hard to
find). May I ask you to explain this better in the CL description (or in the
bug)?

[dullweber, 2017-06-06 09:39:54]

Description was changed from

==========
Replace profile statistics preference count with AutofillCounter

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

to

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the number of
non-default pref values. Even for a new profile, this will be greater than 0
because many preferences are used for things different than settings. This CL
will replace this number with the existing AutofillCounter, that is also used in
Clear Browsing Data because it provides a more meaningful information about
valuable data that will be lost when a profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

[dullweber, 2017-06-06 09:40:17]

Description was changed from

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the number of
non-default pref values. Even for a new profile, this will be greater than 0
because many preferences are used for things different than settings. This CL
will replace this number with the existing AutofillCounter, that is also used in
Clear Browsing Data because it provides a more meaningful information about
valuable data that will be lost when a profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

to

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter, that is also used in Clear Browsing Data 
because it provides a more meaningful information about valuable data 
that will be lost when a profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

[dullweber, 2017-06-06 09:42:05]

Description was changed from

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter, that is also used in Clear Browsing Data 
because it provides a more meaningful information about valuable data 
that will be lost when a profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

to

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

[dullweber, 2017-06-06 09:44:00]

On 2017/06/05 11:46:03, msarda wrote:
> LGTM with a suggestion.
> 
>
https://codereview.chromium.org/2915053002/diff/60001/chrome/browser/profiles...
> File chrome/browser/profiles/profile_statistics_common.cc (right):
> 
>
https://codereview.chromium.org/2915053002/diff/60001/chrome/browser/profiles...
> chrome/browser/profiles/profile_statistics_common.cc:11: const char
> kProfileStatisticsAutofill[] = "Autofill";
> It was not clear to me from the CL description or from the bugs why we're
> changing from using Settings to Autofill in this CL as this is a product
change
> (I finally found this explanation in a document, but this info was hard to
> find). May I ask you to explain this better in the CL description (or in the
> bug)?

thanks, I updated the CL description with an explanation about why autofill is
used instead of preference counts.

[dullweber, 2017-06-07 12:17:35]

Description was changed from

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.

BUG=716267
==========

to

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.
Change 'Browsing History' to 'Browsing history' for consistency with 'Autofill
form data' and other Clear Browsing Data strings.

BUG=716267
==========

[dullweber, 2017-06-07 12:19:03]

Description was changed from

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail anymore.
Change 'Browsing History' to 'Browsing history' for consistency with 'Autofill
form data' and other Clear Browsing Data strings.

BUG=716267
==========

to

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail 
anymore.
Change 'Browsing History' to 'Browsing history' for consistency with
'Autofill form data' and other Clear Browsing Data strings.

BUG=716267
==========

[dullweber, 2017-06-07 12:19:57]

dullweber@chromium.org changed reviewers:
+ michaelpg@chromium.org, xiyuan@chromium.org

[dullweber, 2017-06-07 12:19:58]

michaelpg@chromium.org: Please review changes in 
chrome/browser/ui/webui/

xiyuan@chromium.org: Please review changes in 
ui/login/account_picker/

[xiyuan, 2017-06-07 15:11:34]

ui/login/account_picker/ lgtm

[michaelpg, 2017-06-07 18:25:54]

https://codereview.chromium.org/2915053002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right):

https://codereview.chromium.org/2915053002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:640:
stat->SetIntegerWithoutPathExpansion("success", true);
should this be removed as well? if not, why Boolean => Integer?

[dullweber, 2017-06-08 10:04:05]

Patchset #5 (id:100001) has been deleted

[dullweber, 2017-06-08 10:53:40]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 10:53:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-06-08 10:55:55]

https://codereview.chromium.org/2915053002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right):

https://codereview.chromium.org/2915053002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:640:
stat->SetIntegerWithoutPathExpansion("success", true);
On 2017/06/07 18:25:54, michaelpg wrote:
> should this be removed as well? if not, why Boolean => Integer?

oh, thanks for catching this. 
I removed it at first but noticed that the javascript needs to know which
categories it's going to receive in order check if everything has been
calculated and when to update the total number of items that are going to be
deleted. The initial value is false (line 950).
I must have copied the line from above when I added it again.

[commit-bot: I haz the power, 2017-06-08 11:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 11:53:41]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-06-08 21:11:55]

webui lgtm

[dullweber, 2017-06-14 07:49:04]

The CQ bit was checked by dullweber@chromium.org

[dullweber, 2017-06-14 07:49:04]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org,
xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2915053002/#ps140001
(title: "change to SetBooleanWithoutPathExpansion")

[commit-bot: I haz the power, 2017-06-14 07:49:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 09:30:29]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1497426544166540,
"parent_rev": "93d013d8cd6a86cc366aa46ccf2f1f51361e159b", "commit_rev":
"17645964f33b591deea14589845132be05e8ad9f"}

[commit-bot: I haz the power, 2017-06-14 09:30:41]

Description was changed from

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail 
anymore.
Change 'Browsing History' to 'Browsing history' for consistency with
'Autofill form data' and other Clear Browsing Data strings.

BUG=716267
==========

to

==========
Replace profile statistics preference count with AutofillCounter

The preference count is not very meaningful because it counts the 
number of non-default pref values. Even for a new profile, this will 
be greater than 0 because many preferences are used for things 
different than settings. This CL will replace this number with the 
existing AutofillCounter. The number of autofill forms provides more 
meaningful information about valuable data that will be lost when a 
profile is deleted.

Remove ProfileStatisticsAggregator refcounting because all counters
can be deleted at any time.
Remove ProfileCategoryStat.success because the counters can't fail 
anymore.
Change 'Browsing History' to 'Browsing history' for consistency with
'Autofill form data' and other Clear Browsing Data strings.

BUG=716267

Review-Url: https://codereview.chromium.org/2915053002
Cr-Commit-Position: refs/heads/master@{#479336}
Committed:
https://chromium.googlesource.com/chromium/src/+/17645964f33b591deea145898451...
==========

[commit-bot: I haz the power, 2017-06-14 09:30:42]

Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/17645964f33b591deea145898451...