Replace profile statistics preference count with AutofillCounter

chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/user_manager_screen_handler.h"
 
 #include <stddef.h>
 
 #include <utility>
 #include <vector>
@@ skipping 617 matching lines @@
   }
 }
 
 void UserManagerScreenHandler::RemoveUserDialogLoadStatsCallback(
     base::FilePath profile_path,
     base::Time start_time,
     profiles::ProfileCategoryStats result) {
   // Copy result into return_value.
   base::DictionaryValue return_value;
   for (const auto& item : result) {
-    std::unique_ptr<base::DictionaryValue> stat(new base::DictionaryValue);
+    auto stat = base::MakeUnique<base::DictionaryValue>();
     stat->SetIntegerWithoutPathExpansion("count", item.count);
-    stat->SetBooleanWithoutPathExpansion("success", item.success);
+    stat->SetIntegerWithoutPathExpansion("success", true);

[michaelpg, 2017/06/07 18:25:54]

should this be removed as well? if not, why Boolean => Integer?

[dullweber, 2017/06/08 10:55:55]

oh, thanks for catching this. 
I removed it at first but noticed that the javascript needs to know which
categories it's going to receive in order check if everything has been
calculated and when to update the total number of items that are going to be
deleted. The initial value is false (line 950).
I must have copied the line from above when I added it again. 

     return_value.SetWithoutPathExpansion(item.category, std::move(stat));
   }
   if (result.size() == profiles::kProfileStatisticsCategories.size()) {
     // All categories are finished.
     UMA_HISTOGRAM_TIMES("Profile.RemoveUserWarningStatsTime",
                         base::Time::Now() - start_time);
   }
   web_ui()->CallJavascriptFunctionUnsafe("updateRemoveWarningDialog",
                                          base::Value(profile_path.value()),
                                          return_value);
@@ skipping 147 matching lines @@
           IDS_LOGIN_POD_USER_REMOVE_WARNING_NONSYNC_NOSTATS));
   localized_strings->SetString("removeUserWarningTextNonSyncCalculating",
       l10n_util::GetStringUTF16(
           IDS_LOGIN_POD_USER_REMOVE_WARNING_NONSYNC_CALCULATING));
   localized_strings->SetString("removeUserWarningTextHistory",
       l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_HISTORY));
   localized_strings->SetString("removeUserWarningTextPasswords",
       l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_PASSWORDS));
   localized_strings->SetString("removeUserWarningTextBookmarks",
       l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_BOOKMARKS));
-  localized_strings->SetString("removeUserWarningTextSettings",
-      l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_SETTINGS));
+  localized_strings->SetString(
+      "removeUserWarningTextAutofill",
+      l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_AUTOFILL));
   localized_strings->SetString("removeUserWarningTextCalculating",
       l10n_util::GetStringUTF16(IDS_LOGIN_POD_USER_REMOVE_WARNING_CALCULATING));
   localized_strings->SetString("removeUserWarningTextSyncNoStats",
       l10n_util::GetStringUTF16(
           IDS_LOGIN_POD_USER_REMOVE_WARNING_SYNC_NOSTATS));
   localized_strings->SetString("removeUserWarningTextSyncCalculating",
       l10n_util::GetStringUTF16(
           IDS_LOGIN_POD_USER_REMOVE_WARNING_SYNC_CALCULATING));
   localized_strings->SetString("removeLegacySupervisedUserWarningText",
       l10n_util::GetStringFUTF16(
@@ skipping 224 matching lines @@
     Profile* profile, Profile::CreateStatus profile_create_status) {
   Browser* browser = chrome::FindAnyBrowser(profile, false);
   if (browser && browser->window()) {
     OnBrowserWindowReady(browser);
   } else {
     registrar_.Add(this,
                    chrome::NOTIFICATION_BROWSER_WINDOW_READY,
                    content::NotificationService::AllSources());
   }
 }