[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Taking over CL 2894003002
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2915043003
Cr-Commit-Position: refs/heads/master@{#480840}
Committed: https://chromium.googlesource.com/chromium/src/+/53b386b2023bf1cbf33dee808489ac05ea648d86

[stkhapugin, 2017-06-01 17:15:20]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 17:15:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 17:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 17:22:36]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-06-01 17:27:40]

stkhapugin@chromium.org changed reviewers:
+ rohitrao@chromium.org

[stkhapugin, 2017-06-01 17:27:41]

PTAL.
I'm taking over https://codereview.chromium.org/2894003002 since Lindsay's
rotation is over.

[stkhapugin, 2017-06-02 12:12:41]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 12:12:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 14:43:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 14:43:50]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-06-05 14:33:13]

https://codereview.chromium.org/2915043003/diff/1/ios/chrome/app/safe_mode/sa...
File ios/chrome/app/safe_mode/safe_mode_view_controller.mm (right):

https://codereview.chromium.org/2915043003/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_view_controller.mm:270:
uploadStartTime_.reset([NSDate date]);
Could all of these ivars move out of the header (and stop being
scoped_nsobjects)?

[stkhapugin, 2017-06-15 16:26:38]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[stkhapugin, 2017-06-15 16:26:49]

Thanks, PTAL

https://codereview.chromium.org/2915043003/diff/1/ios/chrome/app/safe_mode/sa...
File ios/chrome/app/safe_mode/safe_mode_view_controller.mm (right):

https://codereview.chromium.org/2915043003/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_view_controller.mm:270:
uploadStartTime_.reset([NSDate date]);
On 2017/06/05 14:33:13, rohitrao (ping after 24h) wrote:
> Could all of these ivars move out of the header (and stop being
> scoped_nsobjects)?

Done

[commit-bot: I haz the power, 2017-06-15 16:26:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 16:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 16:38:46]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[stkhapugin, 2017-06-15 17:22:06]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 17:22:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 19:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 19:10:18]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-06-16 15:00:58]

stkhapugin@chromium.org changed reviewers:
+ marq@chromium.org

[stkhapugin, 2017-06-16 15:00:59]

Mark, can you PTAL? :)

[marq (ping after 24h), 2017-06-19 11:00:01]

lgtm

[rohitrao (ping after 24h), 2017-06-19 12:37:29]

Also lgtm

[stkhapugin, 2017-06-20 14:39:12]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-06-20 14:39:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 16:08:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497969552694500,
"parent_rev": "460e1336e8c401ffaab4a4a340e944982719c537", "commit_rev":
"53b386b2023bf1cbf33dee808489ac05ea648d86"}

[commit-bot: I haz the power, 2017-06-20 16:09:10]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Taking over CL 2894003002
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Taking over CL 2894003002
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2915043003
Cr-Commit-Position: refs/heads/master@{#480840}
Committed:
https://chromium.googlesource.com/chromium/src/+/53b386b2023bf1cbf33dee808489...
==========

[commit-bot: I haz the power, 2017-06-20 16:09:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53b386b2023bf1cbf33dee808489...