[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

ios/chrome/app/safe_mode/safe_mode_view_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/app/safe_mode/safe_mode_view_controller.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include "base/strings/sys_string_conversions.h"
 #import "ios/chrome/app/safe_mode_crashing_modules_config.h"
 #import "ios/chrome/app/safe_mode_util.h"
 #include "ios/chrome/browser/crash_report/breakpad_helper.h"
 #import "ios/chrome/browser/ui/fancy_ui/primary_action_button.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #import "ui/gfx/ios/NSString+CrStringDrawing.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 const CGFloat kVerticalSpacing = 20;
 const CGFloat kUploadProgressSpacing = 5;
 const NSTimeInterval kUploadPumpInterval = 0.1;
 const NSTimeInterval kUploadTotalTime = 5;
 }  // anonymous namespace
 
 @interface SafeModeViewController ()
 // Returns |YES| if any third-party modifications are detected.
 + (BOOL)detectedThirdPartyMods;
@@ skipping 103 matching lines @@
   CGRect mainBounds = [[UIScreen mainScreen] bounds];
   // SafeModeViewController only supports portrait orientation (see
   // implementation of supportedInterfaceOrientations: below) but if the app is
   // launched from landscape mode (e.g. iPad or iPhone 6+) then the mainScreen's
   // bounds will still be landscape at this point. Swap the height and width
   // here so that the dimensions will be correct once the app rotates to
   // portrait.
   if (IsLandscape()) {
     mainBounds.size = CGSizeMake(mainBounds.size.height, mainBounds.size.width);
   }
-  base::scoped_nsobject<UIScrollView> scrollView(
-      [[UIScrollView alloc] initWithFrame:mainBounds]);
+  UIScrollView* scrollView = [[UIScrollView alloc] initWithFrame:mainBounds];
   self.view = scrollView;
   [self.view setBackgroundColor:[UIColor colorWithWhite:0.902 alpha:1.0]];
   const CGFloat kIPadInset =
       (mainBounds.size.width - kIPadWidth - kHorizontalSpacing) / 2;
   const CGFloat widthInset = IsIPadIdiom() ? kIPadInset : kHorizontalSpacing;
   innerView_.reset([[UIView alloc]
       initWithFrame:CGRectInset(mainBounds, widthInset, kVerticalSpacing * 2)]);
   [innerView_ setBackgroundColor:[UIColor whiteColor]];
   [innerView_ layer].cornerRadius = 3;
   [innerView_ layer].borderWidth = 1;
   [innerView_ layer].borderColor =
       [UIColor colorWithWhite:0.851 alpha:1.0].CGColor;
   [innerView_ layer].masksToBounds = YES;
   [scrollView addSubview:innerView_];
 
   UIImage* fatalImage = [UIImage imageNamed:@"fatal_error.png"];
-  base::scoped_nsobject<UIImageView> imageView(
-      [[UIImageView alloc] initWithImage:fatalImage]);
+  UIImageView* imageView = [[UIImageView alloc] initWithImage:fatalImage];
   // Shift the image down a bit.
   CGRect imageFrame = [imageView frame];
   imageFrame.origin.y = kVerticalSpacing;
   [imageView setFrame:imageFrame];
   [self centerView:imageView afterView:nil];
   [innerView_ addSubview:imageView];
 
-  base::scoped_nsobject<UILabel> awSnap([[UILabel alloc] init]);
+  UILabel* awSnap = [[UILabel alloc] init];
   [awSnap setText:NSLocalizedString(@"IDS_IOS_SAFE_MODE_AW_SNAP", @"")];
   [awSnap setBackgroundColor:[UIColor clearColor]];
   [awSnap setTextColor:[UIColor blackColor]];
   [awSnap setFont:[UIFont boldSystemFontOfSize:21]];
   [awSnap sizeToFit];
   [self centerView:awSnap afterView:imageView];
   [innerView_ addSubview:awSnap];
 
-  base::scoped_nsobject<UILabel> description([[UILabel alloc] init]);
+  UILabel* description = [[UILabel alloc] init];
   [description setText:[self startupCrashModuleText]];
   [description setBackgroundColor:[UIColor clearColor]];
   [description setTextColor:[UIColor colorWithWhite:0.31 alpha:1.0]];
   [description setTextAlignment:NSTextAlignmentCenter];
   [description setNumberOfLines:0];
   [description setLineBreakMode:NSLineBreakByWordWrapping];
   CGRect frame = [description frame];
   frame.size.width = IsIPadIdiom() ? kIPadWidth : kIPhoneWidth;
   CGSize maxSize = CGSizeMake(frame.size.width, 999999.0f);
   frame.size.height =
@@ skipping 69 matching lines @@
   [scrollView setContentSize:scrollSize];
 }
 
 - (NSUInteger)supportedInterfaceOrientations {
   return UIInterfaceOrientationMaskPortrait;
 }
 
 #pragma mark - Private
 
 - (void)startUploadProgress {
-  uploadStartTime_.reset([[NSDate date] retain]);
-  uploadTimer_.reset(
-      [[NSTimer scheduledTimerWithTimeInterval:kUploadPumpInterval
-                                        target:self
-                                      selector:@selector(pumpUploadProgress)
-                                      userInfo:nil
-                                       repeats:YES] retain]);
+  uploadStartTime_.reset([NSDate date]);

[rohitrao (ping after 24h), 2017/06/05 14:33:13]

Could all of these ivars move out of the header (and stop being
scoped_nsobjects)?

[stkhapugin, 2017/06/15 16:26:48]

Done

+  uploadTimer_.reset([NSTimer
+      scheduledTimerWithTimeInterval:kUploadPumpInterval
+                              target:self
+                            selector:@selector(pumpUploadProgress)
+                            userInfo:nil
+                             repeats:YES]);
 }
 
 - (void)pumpUploadProgress {
   NSTimeInterval elapsed =
       [[NSDate date] timeIntervalSinceDate:uploadStartTime_];
   // Theoretically we could stop early when the value returned by
   // ios_internal::breakpad::GetCrashReportCount() changes, but this is
   // simpler. If we decide to look for a change in crash report count, then we
   // also probably want to replace the UIProgressView with a
   // UIActivityIndicatorView.
@@ skipping 11 matching lines @@
     [uploadProgress_ setHidden:YES];
   }
 }
 
 - (void)startBrowserFromSafeMode {
   breakpad_helper::RestoreDefaultConfiguration();
   [delegate_ startBrowserFromSafeMode];
 }
 
 @end