[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

[lindsayw, 2017-05-18 19:23:39]

The CQ bit was checked by lindsayw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 19:25:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 21:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 21:55:41]

Dry run: This issue passed the CQ dry run.

[lindsayw, 2017-05-19 12:03:06]

lindsayw@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[lindsayw, 2017-05-19 12:03:07]

Thanks for the review!

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
File ios/chrome/app/safe_mode/safe_mode_coordinator.mm (right):

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:19: // Weak pointer to window
passed on init.
stk@ Please let me know how you would like these comments updated.

[lindsayw, 2017-05-25 14:54:36]

lindsayw@chromium.org changed reviewers:
+ rohitrao@chromium.org
- stkhapugin@chromium.org

[lindsayw, 2017-05-25 14:54:36]

Hi Rohit,
Can you please review since Paris is out and you are owner?
Thanks!

[lindsayw, 2017-05-30 11:53:26]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/app/safe_mode:safe_mode to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

[lindsayw, 2017-05-30 11:53:26]

lindsayw@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[stkhapugin, 2017-05-30 13:36:37]

LGTM with comments. Please file a bug to cleanup safe_mode_view_controller.h
from WeakNSObject, scoped_nsobject - I imagine those cannot be simply moved to
safe_mode_view_controller.mm because the unit test directly accesses them, so
it's a bit more work. Feel free to assign it to me right away and put the bug in
BUG= field of this CL.

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
File ios/chrome/app/safe_mode/safe_mode_coordinator.mm (right):

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:5: #import
"ios/chrome/app/safe_mode/safe_mode_coordinator.h"
In this header, update:

@property(nonatomic, nullable, assign) id<SafeModeCoordinatorDelegate> delegate;

to:

@property(nonatomic, nullable, weak) id<SafeModeCoordinatorDelegate> delegate;

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:19: // Weak pointer to window
passed on init.
On 2017/05/19 12:03:07, lindsayw wrote:
> stk@ Please let me know how you would like these comments updated.

I'm okay with keeping them as is.

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:22: __weak
id<SafeModeCoordinatorDelegate> _delegate;
Remove this ivar and put:

@implementation SafeModeCoordinator
@synthesize delegate = _delegate;

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:31: -
(id<SafeModeCoordinatorDelegate>)delegate {
Remove this getter

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:36: _delegate = delegate;
Remove this setter.

[rohitrao (ping after 24h), 2017-05-30 15:05:07]

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
File ios/chrome/app/safe_mode/safe_mode_coordinator.mm (right):

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:5: #import
"ios/chrome/app/safe_mode/safe_mode_coordinator.h"
On 2017/05/30 13:36:37, stkhapugin wrote:
> In this header, update:
> 
> @property(nonatomic, nullable, assign) id<SafeModeCoordinatorDelegate>
delegate;
> 
> to:
> 
> @property(nonatomic, nullable, weak) id<SafeModeCoordinatorDelegate> delegate;

Should the migration tools be updating header files?  Why didn't they update
this one?

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:19: // Weak pointer to window
passed on init.
On 2017/05/30 13:36:37, stkhapugin wrote:
> On 2017/05/19 12:03:07, lindsayw wrote:
> > stk@ Please let me know how you would like these comments updated.
> 
> I'm okay with keeping them as is. 

I would just get rid of the comments on lines 19 and 21.  I don't think they add
much now that the variables themselves are annotated.

[lindsayw, 2017-06-01 15:35:44]

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
File ios/chrome/app/safe_mode/safe_mode_coordinator.mm (right):

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:5: #import
"ios/chrome/app/safe_mode/safe_mode_coordinator.h"
On 2017/05/30 13:36:37, stkhapugin wrote:
> In this header, update:
> 
> @property(nonatomic, nullable, assign) id<SafeModeCoordinatorDelegate>
delegate;
> 
> to:
> 
> @property(nonatomic, nullable, weak) id<SafeModeCoordinatorDelegate> delegate;

Done.

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:19: // Weak pointer to window
passed on init.
On 2017/05/30 15:05:07, rohitrao (ping after 24h) wrote:
> On 2017/05/30 13:36:37, stkhapugin wrote:
> > On 2017/05/19 12:03:07, lindsayw wrote:
> > > stk@ Please let me know how you would like these comments updated.
> > 
> > I'm okay with keeping them as is. 
> 
> I would just get rid of the comments on lines 19 and 21.  I don't think they
add
> much now that the variables themselves are annotated.

Done.

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:22: __weak
id<SafeModeCoordinatorDelegate> _delegate;
On 2017/05/30 13:36:37, stkhapugin wrote:
> Remove this ivar and put:
> 
> @implementation SafeModeCoordinator
> @synthesize delegate = _delegate; 
> 

Done.

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:31: -
(id<SafeModeCoordinatorDelegate>)delegate {
On 2017/05/30 13:36:37, stkhapugin wrote:
> Remove this getter

Done.

https://codereview.chromium.org/2894003002/diff/1/ios/chrome/app/safe_mode/sa...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:36: _delegate = delegate;
On 2017/05/30 13:36:37, stkhapugin wrote:
> Remove this setter.

Done.

[lindsayw, 2017-06-01 15:36:17]

The CQ bit was checked by lindsayw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 15:36:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 15:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 15:45:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[rohitrao (ping after 24h), 2017-06-01 17:29:02]

lgtm after fixing the rebase issues

https://codereview.chromium.org/2894003002/diff/20001/ios/chrome/app/safe_mod...
File ios/chrome/app/safe_mode/safe_mode_coordinator.mm (right):

https://codereview.chromium.org/2894003002/diff/20001/ios/chrome/app/safe_mod...
ios/chrome/app/safe_mode/safe_mode_coordinator.mm:21: @synthesize delegate =
_delegate;
This looks like a busted rebase.

[lindsayw, 2017-06-01 18:44:49]

On 2017/06/01 17:29:02, rohitrao (ping after 24h) wrote:
> lgtm after fixing the rebase issues
> 
>
https://codereview.chromium.org/2894003002/diff/20001/ios/chrome/app/safe_mod...
> File ios/chrome/app/safe_mode/safe_mode_coordinator.mm (right):
> 
>
https://codereview.chromium.org/2894003002/diff/20001/ios/chrome/app/safe_mod...
> ios/chrome/app/safe_mode/safe_mode_coordinator.mm:21: @synthesize delegate =
> _delegate;
> This looks like a busted rebase.

There were a few other things to address so stepan will take over the patch in
https://codereview.chromium.org/2915043003/. I'll close this CL.