Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2914943002: Use correct error code: REFUSED_STREAM to reject server push from the server in SPDY (Closed)

Created:
3 years, 6 months ago by Zhongyi Shi
Modified:
3 years, 6 months ago
Reviewers:
Buck, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct error code: REFUSED_STREAM to reject server push from the server in SPDY. BUG=726725 Review-Url: https://codereview.chromium.org/2914943002 Cr-Commit-Position: refs/heads/master@{#476147} Committed: https://chromium.googlesource.com/chromium/src/+/4f304415e461ebcb905767d603cc580e691b81a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/spdy/chromium/spdy_network_transaction_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/chromium/spdy_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Zhongyi Shi
3 years, 6 months ago (2017-05-31 23:23:32 UTC) #3
Buck
lgtm
3 years, 6 months ago (2017-05-31 23:29:31 UTC) #4
Ryan Hamilton
lgtm
3 years, 6 months ago (2017-05-31 23:52:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914943002/1
3 years, 6 months ago (2017-06-01 00:14:37 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 02:00:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f304415e461ebcb905767d603cc...

Powered by Google App Engine
This is Rietveld 408576698