Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: net/spdy/chromium/spdy_session.cc

Issue 2914943002: Use correct error code: REFUSED_STREAM to reject server push from the server in SPDY (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/chromium/spdy_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/chromium/spdy_session.cc
diff --git a/net/spdy/chromium/spdy_session.cc b/net/spdy/chromium/spdy_session.cc
index 7158a1fa84eaf68e418da894fa7fab301e07fe1d..57519f1a3daea2da125922b3b12c1bc62a8ad2f9 100644
--- a/net/spdy/chromium/spdy_session.cc
+++ b/net/spdy/chromium/spdy_session.cc
@@ -1591,7 +1591,7 @@ void SpdySession::TryCreatePushStream(SpdyStreamId stream_id,
GURL gurl = GetUrlFromHeaderBlock(headers);
if (!gurl.is_valid()) {
EnqueueResetStreamFrame(
- stream_id, request_priority, ERROR_CODE_PROTOCOL_ERROR,
+ stream_id, request_priority, ERROR_CODE_REFUSED_STREAM,
"Pushed stream url was invalid: " + gurl.possibly_invalid_spec());
return;
}
@@ -1660,7 +1660,7 @@ void SpdySession::TryCreatePushStream(SpdyStreamId stream_id,
if (pushed_it != unclaimed_pushed_streams_.end() &&
pushed_it->first == gurl) {
EnqueueResetStreamFrame(
- stream_id, request_priority, ERROR_CODE_PROTOCOL_ERROR,
+ stream_id, request_priority, ERROR_CODE_REFUSED_STREAM,
"Received duplicate pushed stream with url: " + gurl.spec());
return;
}
« no previous file with comments | « net/spdy/chromium/spdy_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698