Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: net/spdy/chromium/spdy_network_transaction_unittest.cc

Issue 2914943002: Use correct error code: REFUSED_STREAM to reject server push from the server in SPDY (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/chromium/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/chromium/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/chromium/spdy_network_transaction_unittest.cc b/net/spdy/chromium/spdy_network_transaction_unittest.cc
index c962b9060e9d0bfb7e3775172bfb4892ee4ec3c1..3c5183ec3b8f63011f106c332dde85d5a8fe9776 100644
--- a/net/spdy/chromium/spdy_network_transaction_unittest.cc
+++ b/net/spdy/chromium/spdy_network_transaction_unittest.cc
@@ -2748,7 +2748,7 @@ TEST_F(SpdyNetworkTransactionTest, ServerPushDuplicate) {
SpdySerializedFrame stream2_priority(
spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true));
SpdySerializedFrame stream3_rst(
- spdy_util_.ConstructSpdyRstStream(4, ERROR_CODE_PROTOCOL_ERROR));
+ spdy_util_.ConstructSpdyRstStream(4, ERROR_CODE_REFUSED_STREAM));
MockWrite writes[] = {
CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3),
CreateMockWrite(stream3_rst, 5),
@@ -2918,7 +2918,7 @@ TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidUrl) {
response_spdy_framer.SerializeFrame(push_promise));
SpdySerializedFrame stream2_rst(
- spdy_util_.ConstructSpdyRstStream(2, ERROR_CODE_PROTOCOL_ERROR));
+ spdy_util_.ConstructSpdyRstStream(2, ERROR_CODE_REFUSED_STREAM));
MockWrite writes[] = {CreateMockWrite(req, 0),
CreateMockWrite(stream2_rst, 2)};
@@ -2978,7 +2978,7 @@ TEST_F(SpdyNetworkTransactionTest, ServerPushNoURL) {
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST, true));
SpdySerializedFrame stream1_body(spdy_util_.ConstructSpdyDataFrame(1, true));
SpdySerializedFrame stream2_rst(
- spdy_util_.ConstructSpdyRstStream(2, ERROR_CODE_PROTOCOL_ERROR));
+ spdy_util_.ConstructSpdyRstStream(2, ERROR_CODE_REFUSED_STREAM));
MockWrite writes[] = {
CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_rst, 3),
};
« no previous file with comments | « no previous file | net/spdy/chromium/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698