Issue 291493004: Domain Reliability: Deduplicate some code into test_util

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291493004: Domain Reliability: Deduplicate some code into test_util (Closed)

Created:
6 years, 7 months ago by Deprecated (see juliatuttle)

Modified:
6 years, 7 months ago

Reviewers:
davidben

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Domain Reliability: Deduplicate some code into test_util We'd grown a couple of copies of code to create various test objects. Deduplicate them into test_util and call them there. BUG=356791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271043

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -85 lines)			Patch
M	components/domain_reliability/context_unittest.cc	View	3 chunks	+2 lines, -38 lines	0 comments	Download
M	components/domain_reliability/monitor_unittest.cc	View	2 chunks	+1 line, -38 lines	0 comments	Download
M	components/domain_reliability/scheduler_unittest.cc	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	components/domain_reliability/test_util.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	components/domain_reliability/test_util.cc	View	2 chunks	+43 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Deprecated (see juliatuttle)

The CQ bit was checked by ttuttle@chromium.org

6 years, 7 months ago (2014-05-16 16:25:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/291493004/1

6 years, 7 months ago (2014-05-16 16:26:00 UTC) #4

Message was sent while issue was closed.

Change committed as 271043