Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6181)

Unified Diff: components/domain_reliability/scheduler_unittest.cc

Issue 291493004: Domain Reliability: Deduplicate some code into test_util (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/monitor_unittest.cc ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/scheduler_unittest.cc
diff --git a/components/domain_reliability/scheduler_unittest.cc b/components/domain_reliability/scheduler_unittest.cc
index 57df6f21740478857b83995b951472acbd0b1138..16ae6395489b6d5e7c3e1690d383f39b64683fce 100644
--- a/components/domain_reliability/scheduler_unittest.cc
+++ b/components/domain_reliability/scheduler_unittest.cc
@@ -21,7 +21,7 @@ class DomainReliabilitySchedulerTest : public testing::Test {
public:
DomainReliabilitySchedulerTest()
: num_collectors_(0),
- params_(CreateDefaultParams()),
+ params_(MakeTestSchedulerParams()),
callback_called_(false) {}
void CreateScheduler(int num_collectors) {
@@ -37,14 +37,6 @@ class DomainReliabilitySchedulerTest : public testing::Test {
base::Unretained(this))));
}
- static DomainReliabilityScheduler::Params CreateDefaultParams() {
- DomainReliabilityScheduler::Params params;
- params.minimum_upload_delay = base::TimeDelta::FromSeconds(60);
- params.maximum_upload_delay = base::TimeDelta::FromSeconds(300);
- params.upload_retry_interval = base::TimeDelta::FromSeconds(15);
- return params;
- }
-
::testing::AssertionResult CheckNoPendingUpload() {
DCHECK(scheduler_);
« no previous file with comments | « components/domain_reliability/monitor_unittest.cc ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698