Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: components/domain_reliability/monitor_unittest.cc

Issue 291493004: Domain Reliability: Deduplicate some code into test_util (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/monitor_unittest.cc
diff --git a/components/domain_reliability/monitor_unittest.cc b/components/domain_reliability/monitor_unittest.cc
index 84f3067d2fd12f2a5df5cbdb85dba3180dfb8609..ad8fd155350dee7b34124648e23833ffde7cf98c 100644
--- a/components/domain_reliability/monitor_unittest.cc
+++ b/components/domain_reliability/monitor_unittest.cc
@@ -41,43 +41,6 @@ scoped_refptr<net::HttpResponseHeaders> MakeHttpResponseHeaders(
headers.c_str(), headers.length())));
}
-static scoped_ptr<const DomainReliabilityConfig> MakeConfig() {
- DomainReliabilityConfig* config = new DomainReliabilityConfig();
-
- DomainReliabilityConfig::Resource* resource;
-
- resource = new DomainReliabilityConfig::Resource();
- resource->name = "always_report";
- resource->url_patterns.push_back(
- new std::string("http://example/always_report"));
- resource->success_sample_rate = 1.0;
- resource->failure_sample_rate = 1.0;
- EXPECT_TRUE(resource->IsValid());
- config->resources.push_back(resource);
-
- resource = new DomainReliabilityConfig::Resource();
- resource->name = "never_report";
- resource->url_patterns.push_back(
- new std::string("http://example/never_report"));
- resource->success_sample_rate = 0.0;
- resource->failure_sample_rate = 0.0;
- EXPECT_TRUE(resource->IsValid());
- config->resources.push_back(resource);
-
- DomainReliabilityConfig::Collector* collector;
- collector = new DomainReliabilityConfig::Collector();
- collector->upload_url = GURL("https://example/upload");
- EXPECT_TRUE(collector->IsValid());
- config->collectors.push_back(collector);
-
- config->version = "1";
- config->valid_until = 1234567890.0;
- config->domain = "example";
- EXPECT_TRUE(config->IsValid());
-
- return scoped_ptr<const DomainReliabilityConfig>(config);
-}
-
} // namespace
class DomainReliabilityMonitorTest : public testing::Test {
@@ -92,7 +55,7 @@ class DomainReliabilityMonitorTest : public testing::Test {
monitor_(url_request_context_getter_->GetURLRequestContext(),
"test-reporter",
scoped_ptr<MockableTime>(time_)),
- context_(monitor_.AddContextForTesting(MakeConfig())) {}
+ context_(monitor_.AddContextForTesting(MakeTestConfig())) {}
static RequestInfo MakeRequestInfo() {
RequestInfo request;
« no previous file with comments | « components/domain_reliability/context_unittest.cc ('k') | components/domain_reliability/scheduler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698