Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: components/domain_reliability/context_unittest.cc

Issue 291493004: Domain Reliability: Deduplicate some code into test_util (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/domain_reliability/monitor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/context_unittest.cc
diff --git a/components/domain_reliability/context_unittest.cc b/components/domain_reliability/context_unittest.cc
index bcd1ac67be398c5f4d50e60f3173791945172625..7bb79f2d39d1b40375c524106b7a0e08ab1103b3 100644
--- a/components/domain_reliability/context_unittest.cc
+++ b/components/domain_reliability/context_unittest.cc
@@ -37,7 +37,7 @@ class DomainReliabilityContextTest : public testing::Test {
protected:
DomainReliabilityContextTest()
: dispatcher_(&time_),
- params_(CreateParams()),
+ params_(MakeTestSchedulerParams()),
uploader_(base::Bind(&DomainReliabilityContextTest::OnUploadRequest,
base::Unretained(this))),
upload_reporter_string_("test-reporter"),
@@ -46,7 +46,7 @@ class DomainReliabilityContextTest : public testing::Test {
upload_reporter_string_,
&dispatcher_,
&uploader_,
- CreateConfig().Pass()),
+ MakeTestConfig().Pass()),
upload_pending_(false) {}
TimeDelta min_delay() const { return params_.minimum_upload_delay; }
@@ -105,42 +105,6 @@ class DomainReliabilityContextTest : public testing::Test {
upload_pending_ = true;
}
- static DomainReliabilityScheduler::Params CreateParams() {
- DomainReliabilityScheduler::Params params;
- params.minimum_upload_delay = base::TimeDelta::FromSeconds(60);
- params.maximum_upload_delay = base::TimeDelta::FromSeconds(300);
- params.upload_retry_interval = base::TimeDelta::FromSeconds(15);
- return params;
- }
-
- static scoped_ptr<const DomainReliabilityConfig> CreateConfig() {
- DomainReliabilityConfig* config = new DomainReliabilityConfig();
- DomainReliabilityConfig::Resource* resource;
-
- resource = new DomainReliabilityConfig::Resource();
- resource->name = "always_report";
- resource->url_patterns.push_back(
- new std::string("http://example/always_report"));
- resource->success_sample_rate = 1.0;
- resource->failure_sample_rate = 1.0;
- config->resources.push_back(resource);
-
- resource = new DomainReliabilityConfig::Resource();
- resource->name = "never_report";
- resource->url_patterns.push_back(
- new std::string("http://example/never_report"));
- resource->success_sample_rate = 0.0;
- resource->failure_sample_rate = 0.0;
- config->resources.push_back(resource);
-
- DomainReliabilityConfig::Collector* collector;
- collector = new DomainReliabilityConfig::Collector();
- collector->upload_url = GURL("https://example/upload");
- config->collectors.push_back(collector);
-
- return scoped_ptr<const DomainReliabilityConfig>(config);
- }
-
bool upload_pending_;
std::string upload_report_;
GURL upload_url_;
« no previous file with comments | « no previous file | components/domain_reliability/monitor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698