Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2914753002: Make TextCombine an enum class. (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, shend, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextCombine an enum class. This patch makes TextCombine an enum class for type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2914753002 Cr-Commit-Position: refs/heads/master@{#475857} Committed: https://chromium.googlesource.com/chromium/src/+/1194384ed753cf828b85f565d555bd2e1b22e9c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
nainar
shend@, PTAL? Thanks!
3 years, 6 months ago (2017-05-31 05:54:04 UTC) #4
shend
lgtm
3 years, 6 months ago (2017-05-31 06:15:55 UTC) #5
nainar
3 years, 6 months ago (2017-05-31 07:38:03 UTC) #9
rune
lgtm
3 years, 6 months ago (2017-05-31 09:28:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914753002/1
3 years, 6 months ago (2017-05-31 09:32:53 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 09:36:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1194384ed753cf828b85f565d555...

Powered by Google App Engine
This is Rietveld 408576698