Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2914753002: Make TextCombine an enum class. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index aec4bd46d6b9d3bdc12a756d13a7e73a06934c55..7d952e6a36fc6fa586890bd12ad72aa14f27244b 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -1669,12 +1669,12 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase<ComputedStyle>,
bool QuotesDataEquivalent(const ComputedStyle&) const;
// text-combine-upright (aka -webkit-text-combine, -epub-text-combine)
- static TextCombine InitialTextCombine() { return kTextCombineNone; }
+ static TextCombine InitialTextCombine() { return TextCombine::kNone; }
TextCombine GetTextCombine() const {
return static_cast<TextCombine>(rare_inherited_data_->text_combine_);
}
void SetTextCombine(TextCombine v) {
- SET_VAR(rare_inherited_data_, text_combine_, v);
+ SET_VAR(rare_inherited_data_, text_combine_, static_cast<unsigned>(v));
}
// text-justify
@@ -2252,7 +2252,7 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase<ComputedStyle>,
}
// Text-combine utility functions.
- bool HasTextCombine() const { return GetTextCombine() != kTextCombineNone; }
+ bool HasTextCombine() const { return GetTextCombine() != TextCombine::kNone; }
// Grid utility functions.
const Vector<GridTrackSize>& GridAutoRepeatColumns() const {

Powered by Google App Engine
This is Rietveld 408576698