Generate enum/getters/setters/mappings for text-combine-upright.

Generate enum/getters/setters/mappings for text-combine-upright.

Currently, the text-combine-upright/{webkit,epub}-combine property is a
'storage_only' field, so it has no generated public getters/setters.
This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the ETextCombine enum and
use the generated CSSValueID <-> ETextCombine mappings.

Diff: https://gist.github.com/nainar/c2f36a25584d2f298ab9090fe308c6e5/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2916523002
Cr-Commit-Position: refs/heads/master@{#475877}
Committed: https://chromium.googlesource.com/chromium/src/+/960ae7f16addc69a2369cda1d8462f0b1850a77e

[nainar, 2017-05-31 07:36:37]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2017-05-31 07:36:49]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-05-31 07:36:49]

shend@, 

PTAL? 

Thanks!

[commit-bot: I haz the power, 2017-05-31 07:36:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 07:39:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 07:39:07]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nainar, 2017-05-31 07:49:49]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 07:50:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-31 07:52:10]

Description was changed from

==========
Generate enum/getters/setters/mappings for text-combime-upright.

Currently, the text-combime-upright/{webkit,epub}-combine property is a
'storage_only' field, so it has no generated public getters/setters.
This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the ETextCombine enum and
use the generated CSSValueID <-> ETextCombine mappings.

Diff: https://gist.github.com/nainar/c2f36a25584d2f298ab9090fe308c6e5/revisions

BUG=628043
==========

to

==========
Generate enum/getters/setters/mappings for text-combine-upright.

Currently, the text-combine-upright/{webkit,epub}-combine property is a
'storage_only' field, so it has no generated public getters/setters.
This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the ETextCombine enum and
use the generated CSSValueID <-> ETextCombine mappings.

Diff: https://gist.github.com/nainar/c2f36a25584d2f298ab9090fe308c6e5/revisions

BUG=628043
==========

[shend, 2017-05-31 07:53:11]

lgtm, interesting that there are no other callers of TextCombine.

https://codereview.chromium.org/2916523002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSValueIDMappings.h (right):

https://codereview.chromium.org/2916523002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSValueIDMappings.h:38: if (v ==
CSSValueHorizontal)
nit: keep the comment from the original code.

[nainar, 2017-05-31 08:24:39]

nainar@chromium.org changed reviewers:
+ meade@chromium.org

[nainar, 2017-05-31 08:24:40]

meade@, 

PTAL? Thanks!

https://codereview.chromium.org/2916523002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSValueIDMappings.h (right):

https://codereview.chromium.org/2916523002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSValueIDMappings.h:38: if (v ==
CSSValueHorizontal)
Done.

[nainar, 2017-05-31 08:24:48]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 08:25:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-05-31 09:25:02]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-05-31 09:25:03]

lgtm

[commit-bot: I haz the power, 2017-05-31 11:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 11:13:19]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-05-31 11:25:55]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-05-31 11:25:55]

The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2916523002/#ps40001
(title: "shend@ suggestions")

[commit-bot: I haz the power, 2017-05-31 11:26:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 11:29:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496229955598860,
"parent_rev": "026068985a0a7ae8e187d62b3abdd85b8a1e9f40", "commit_rev":
"960ae7f16addc69a2369cda1d8462f0b1850a77e"}

[commit-bot: I haz the power, 2017-05-31 11:30:00]

Description was changed from

==========
Generate enum/getters/setters/mappings for text-combine-upright.

Currently, the text-combine-upright/{webkit,epub}-combine property is a
'storage_only' field, so it has no generated public getters/setters.
This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the ETextCombine enum and
use the generated CSSValueID <-> ETextCombine mappings.

Diff: https://gist.github.com/nainar/c2f36a25584d2f298ab9090fe308c6e5/revisions

BUG=628043
==========

to

==========
Generate enum/getters/setters/mappings for text-combine-upright.

Currently, the text-combine-upright/{webkit,epub}-combine property is a
'storage_only' field, so it has no generated public getters/setters.
This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the ETextCombine enum and
use the generated CSSValueID <-> ETextCombine mappings.

Diff: https://gist.github.com/nainar/c2f36a25584d2f298ab9090fe308c6e5/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2916523002
Cr-Commit-Position: refs/heads/master@{#475877}
Committed:
https://chromium.googlesource.com/chromium/src/+/960ae7f16addc69a2369cda1d846...
==========

[commit-bot: I haz the power, 2017-05-31 11:30:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/960ae7f16addc69a2369cda1d846...