Fix crash in hidden <select>

Fix crash in hidden <select>

BUG=726598
Review-Url: https://codereview.chromium.org/2914723002
Cr-Commit-Position: refs/heads/master@{#475742}
Committed: https://chromium.googlesource.com/chromium/src/+/ebd6c13ecdd4e81224ed66fc60fd240cfaae2687

[dmazzoni, 2017-05-31 00:01:15]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-05-31 00:01:15]

lgtm

https://codereview.chromium.org/2914723002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
(right):

https://codereview.chromium.org/2914723002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp:52:
LocalFrameView* AXMenuListOption::DocumentFrameView() const {
Could you implement GetDocument() instead (since DocumentFrameView just calls
Document first, and that would fix Document too)?

Could you move this up to AXMockObject so that it's fixed for any AXMockObject
that still has an associated node?

[aboxhall, 2017-05-31 00:20:08]

https://codereview.chromium.org/2914723002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
(right):

https://codereview.chromium.org/2914723002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp:52:
LocalFrameView* AXMenuListOption::DocumentFrameView() const {
On 2017/05/31 00:01:15, dmazzoni wrote:
> Could you implement GetDocument() instead (since DocumentFrameView just calls
> Document first, and that would fix Document too)?

DocumentFrameView() in AXObjectImpl doesn't call GetDocument() - in fact the
reverse is true.
 
> Could you move this up to AXMockObject so that it's fixed for any AXMockObject
> that still has an associated node?

element_ is a member of AXMenuList. I don't think GetNode() would work, since
it's not an AXNodeObject.

[aboxhall, 2017-05-31 00:21:53]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2017-05-31 00:21:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2914723002/#ps20001
(title: "Remove non-working layout test")

[commit-bot: I haz the power, 2017-05-31 00:23:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:11:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496190113511730,
"parent_rev": "40aa236afea24fc070187505258343bc38c9d694", "commit_rev":
"ebd6c13ecdd4e81224ed66fc60fd240cfaae2687"}

[commit-bot: I haz the power, 2017-05-31 02:11:57]

Description was changed from

==========
Fix crash in hidden <select>

BUG=726598
==========

to

==========
Fix crash in hidden <select>

BUG=726598

Review-Url: https://codereview.chromium.org/2914723002
Cr-Commit-Position: refs/heads/master@{#475742}
Committed:
https://chromium.googlesource.com/chromium/src/+/ebd6c13ecdd4e81224ed66fc60fd...
==========

[commit-bot: I haz the power, 2017-05-31 02:11:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ebd6c13ecdd4e81224ed66fc60fd...