Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

Issue 2914723002: Fix crash in hidden <select> (Closed)
Patch Set: Remove non-working layout test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 private: 46 private:
47 AXMenuListOption(HTMLOptionElement*, AXObjectCacheImpl&); 47 AXMenuListOption(HTMLOptionElement*, AXObjectCacheImpl&);
48 DECLARE_VIRTUAL_TRACE(); 48 DECLARE_VIRTUAL_TRACE();
49 49
50 bool IsMenuListOption() const override { return true; } 50 bool IsMenuListOption() const override { return true; }
51 51
52 Node* GetNode() const override { return element_; } 52 Node* GetNode() const override { return element_; }
53 void Detach() override; 53 void Detach() override;
54 bool IsDetached() const override { return !element_; } 54 bool IsDetached() const override { return !element_; }
55 LocalFrameView* DocumentFrameView() const override;
55 AccessibilityRole RoleValue() const override; 56 AccessibilityRole RoleValue() const override;
56 bool CanHaveChildren() const override { return false; } 57 bool CanHaveChildren() const override { return false; }
57 AXObjectImpl* ComputeParent() const override; 58 AXObjectImpl* ComputeParent() const override;
58 59
59 Element* ActionElement() const override; 60 Element* ActionElement() const override;
60 bool IsEnabled() const override; 61 bool IsEnabled() const override;
61 bool IsVisible() const override; 62 bool IsVisible() const override;
62 bool IsOffScreen() const override; 63 bool IsOffScreen() const override;
63 bool IsSelected() const override; 64 bool IsSelected() const override;
64 void SetSelected(bool) override; 65 void SetSelected(bool) override;
(...skipping 13 matching lines...) Expand all
78 HTMLSelectElement* ParentSelectNode() const; 79 HTMLSelectElement* ParentSelectNode() const;
79 80
80 Member<HTMLOptionElement> element_; 81 Member<HTMLOptionElement> element_;
81 }; 82 };
82 83
83 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuListOption, IsMenuListOption()); 84 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuListOption, IsMenuListOption());
84 85
85 } // namespace blink 86 } // namespace blink
86 87
87 #endif // AXMenuListOption_h 88 #endif // AXMenuListOption_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698