third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h - Issue 2914723002: Fix crash in hidden <select>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

Issue 2914723002: Fix crash in hidden <select> (Closed)

Patch Set: Remove non-working layout test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

index ced0f73d98c01258f1cf41222ed239faefd3b120..32f42e9e85d2652780c6cac86f05d2634d8fffbf 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

@@ -52,6 +52,7 @@ class AXMenuListOption final : public AXMockObject {

Node* GetNode() const override { return element_; }

void Detach() override;

bool IsDetached() const override { return !element_; }

+ LocalFrameView* DocumentFrameView() const override;

AccessibilityRole RoleValue() const override;

bool CanHaveChildren() const override { return false; }

AXObjectImpl* ComputeParent() const override;