Reland of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp

Reland of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp (patchset #4 id:200001 of https://codereview.chromium.org/2812263003/ )

Reason for revert:
Relanding the patch set after the effect of reverting it has been analyzed.

Original issue's description:
> Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp (patchset #1 id:1 of https://codereview.chromium.org/2685673005/ )
> 
> Reason for revert:
> Reverting to see the effect on memory benchmarks.
> BUG=691618
> 
> Original issue's description:
> > Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
> > 
> > This CL replaces base::WorkerPool::PostTask() with
> > base::PostTaskWithTraits(). The following traits are used:
> > 
> > Priority: Inherited (default)
> >   The priority is inherited from the calling context (i.e. TaskTraits
> >   are initialized with the priority of the current task).
> > 
> > Shutdown behavior: CONTINUE_ON_SHUTDOWN
> >   Tasks posted with this mode which have not started executing before
> >   shutdown is initiated will never run. Tasks with this mode running at
> >   shutdown will be ignored (the worker will not be joined).
> > 
> >   Note: Tasks that were previously posted to base::WorkerPool should
> >   use this shutdown behavior because this is how base::WorkerPool
> >   handles all its tasks.
> > 
> > *No* May Block (default):
> >   Tasks may no block on synchronous file I/O operations or on sync
> >   primitives.
> > 
> > BUG=659191
> > 
> > Review-Url: https://codereview.chromium.org/2685673005
> > Cr-Commit-Position: refs/heads/master@{#449633}
> > Committed: https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e42fcad65e21c8
> 
> TBR=kinuko@chromium.org,haraken@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=659191
> 
> Review-Url: https://codereview.chromium.org/2812263003
> Cr-Commit-Position: refs/heads/master@{#464121}
> Committed: https://chromium.googlesource.com/chromium/src/+/24e5d1ddee9fa61587b6f0279a25792d0208b9f1

TBR=kinuko@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691618
Review-Url: https://codereview.chromium.org/2914633002
Cr-Commit-Position: refs/heads/master@{#475582}
Committed: https://chromium.googlesource.com/chromium/src/+/f23174882c11f77a5b58cf37ab4051a2ad68a4bf

[fdoray, 2017-05-30 14:26:26]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-05-30 14:26:27]

Created Reland of Use TaskScheduler instead of WorkerPool in
BackgroundTaskRunner.cpp

[commit-bot: I haz the power, 2017-05-30 14:26:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 14:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:36:24]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-05-30 14:53:40]

LGTM % you'll need to fix the compile error.

[fdoray, 2017-05-30 15:39:32]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-05-30 15:39:33]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2914633002/#ps70001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-30 15:39:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 17:37:59]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1496158772404810,
"parent_rev": "776b9109e21429a28d7cb4b17a581eabcb3ee27f", "commit_rev":
"f23174882c11f77a5b58cf37ab4051a2ad68a4bf"}

[commit-bot: I haz the power, 2017-05-30 17:38:16]

Description was changed from

==========
Reland of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
(patchset #4 id:200001 of https://codereview.chromium.org/2812263003/ )

Reason for revert:
Relanding the patch set after the effect of reverting it has been analyzed.

Original issue's description:
> Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
(patchset #1 id:1 of https://codereview.chromium.org/2685673005/ )
> 
> Reason for revert:
> Reverting to see the effect on memory benchmarks.
> BUG=691618
> 
> Original issue's description:
> > Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
> > 
> > This CL replaces base::WorkerPool::PostTask() with
> > base::PostTaskWithTraits(). The following traits are used:
> > 
> > Priority: Inherited (default)
> >   The priority is inherited from the calling context (i.e. TaskTraits
> >   are initialized with the priority of the current task).
> > 
> > Shutdown behavior: CONTINUE_ON_SHUTDOWN
> >   Tasks posted with this mode which have not started executing before
> >   shutdown is initiated will never run. Tasks with this mode running at
> >   shutdown will be ignored (the worker will not be joined).
> > 
> >   Note: Tasks that were previously posted to base::WorkerPool should
> >   use this shutdown behavior because this is how base::WorkerPool
> >   handles all its tasks.
> > 
> > *No* May Block (default):
> >   Tasks may no block on synchronous file I/O operations or on sync
> >   primitives.
> > 
> > BUG=659191
> > 
> > Review-Url: https://codereview.chromium.org/2685673005
> > Cr-Commit-Position: refs/heads/master@{#449633}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e4...
> 
> TBR=kinuko@chromium.org,haraken@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=659191
> 
> Review-Url: https://codereview.chromium.org/2812263003
> Cr-Commit-Position: refs/heads/master@{#464121}
> Committed:
https://chromium.googlesource.com/chromium/src/+/24e5d1ddee9fa61587b6f0279a25...

TBR=kinuko@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691618
==========

to

==========
Reland of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
(patchset #4 id:200001 of https://codereview.chromium.org/2812263003/ )

Reason for revert:
Relanding the patch set after the effect of reverting it has been analyzed.

Original issue's description:
> Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
(patchset #1 id:1 of https://codereview.chromium.org/2685673005/ )
> 
> Reason for revert:
> Reverting to see the effect on memory benchmarks.
> BUG=691618
> 
> Original issue's description:
> > Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
> > 
> > This CL replaces base::WorkerPool::PostTask() with
> > base::PostTaskWithTraits(). The following traits are used:
> > 
> > Priority: Inherited (default)
> >   The priority is inherited from the calling context (i.e. TaskTraits
> >   are initialized with the priority of the current task).
> > 
> > Shutdown behavior: CONTINUE_ON_SHUTDOWN
> >   Tasks posted with this mode which have not started executing before
> >   shutdown is initiated will never run. Tasks with this mode running at
> >   shutdown will be ignored (the worker will not be joined).
> > 
> >   Note: Tasks that were previously posted to base::WorkerPool should
> >   use this shutdown behavior because this is how base::WorkerPool
> >   handles all its tasks.
> > 
> > *No* May Block (default):
> >   Tasks may no block on synchronous file I/O operations or on sync
> >   primitives.
> > 
> > BUG=659191
> > 
> > Review-Url: https://codereview.chromium.org/2685673005
> > Cr-Commit-Position: refs/heads/master@{#449633}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e4...
> 
> TBR=kinuko@chromium.org,haraken@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=659191
> 
> Review-Url: https://codereview.chromium.org/2812263003
> Cr-Commit-Position: refs/heads/master@{#464121}
> Committed:
https://chromium.googlesource.com/chromium/src/+/24e5d1ddee9fa61587b6f0279a25...

TBR=kinuko@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691618

Review-Url: https://codereview.chromium.org/2914633002
Cr-Commit-Position: refs/heads/master@{#475582}
Committed:
https://chromium.googlesource.com/chromium/src/+/f23174882c11f77a5b58cf37ab40...
==========

[commit-bot: I haz the power, 2017-05-30 17:38:19]

Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/f23174882c11f77a5b58cf37ab40...

[kinuko, 2017-05-31 03:06:30]

lgtm