Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp

Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits(). The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

*No* May Block (default):
  Tasks may no block on synchronous file I/O operations or on sync
  primitives.

BUG=659191
Review-Url: https://codereview.chromium.org/2685673005
Cr-Commit-Position: refs/heads/master@{#449633}
Committed: https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e42fcad65e21c8

[fdoray, 2017-02-09 13:21:11]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 13:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 15:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 15:06:27]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-02-09 15:12:18]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in polling_proxy_config_service.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits(). The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

*No* May Block (default):
  Tasks may no block on synchronous file I/O operations or on sync
  primitives.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits(). The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

*No* May Block (default):
  Tasks may no block on synchronous file I/O operations or on sync
  primitives.

BUG=659191
==========

[fdoray, 2017-02-09 16:28:44]

fdoray@chromium.org changed reviewers:
+ kinuko@chromium.org

[fdoray, 2017-02-09 16:28:44]

PTAL

[kinuko, 2017-02-09 17:21:16]

lgtm

[fdoray, 2017-02-09 17:38:14]

fdoray@chromium.org changed reviewers:
+ haraken@chromium.org

[fdoray, 2017-02-09 17:38:15]

haraken@chromium.org: Please review changes in
third_party/WebKit/Source/modules/webaudio/

[haraken, 2017-02-10 00:20:59]

LGTM

[fdoray, 2017-02-10 14:13:30]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-02-10 14:13:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 16:42:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486736010581210, "parent_rev":
"328eda136de7172f4970f94774ba68528ab22adc", "commit_rev":
"99e56574537a8cf27af4c86f34e42fcad65e21c8"}

[commit-bot: I haz the power, 2017-02-10 16:42:37]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits(). The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

*No* May Block (default):
  Tasks may no block on synchronous file I/O operations or on sync
  primitives.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits(). The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

*No* May Block (default):
  Tasks may no block on synchronous file I/O operations or on sync
  primitives.

BUG=659191

Review-Url: https://codereview.chromium.org/2685673005
Cr-Commit-Position: refs/heads/master@{#449633}
Committed:
https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e4...
==========

[commit-bot: I haz the power, 2017-02-10 16:42:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e4...

[fdoray, 2017-04-12 16:43:05]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2812263003/ by fdoray@chromium.org.

The reason for reverting is: Reverting to see the effect on memory benchmarks.
BUG=691618.