Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2812263003: Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, hongchan, dglazkov+blink, Rik, blink-reviews, kinuko+watch, Raymond Toy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp (patchset #1 id:1 of https://codereview.chromium.org/2685673005/ ) Reason for revert: Reverting to see the effect on memory benchmarks. BUG=691618 Original issue's description: > Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp > > This CL replaces base::WorkerPool::PostTask() with > base::PostTaskWithTraits(). The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > *No* May Block (default): > Tasks may no block on synchronous file I/O operations or on sync > primitives. > > BUG=659191 > > Review-Url: https://codereview.chromium.org/2685673005 > Cr-Commit-Position: refs/heads/master@{#449633} > Committed: https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e42fcad65e21c8 TBR=kinuko@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659191 Review-Url: https://codereview.chromium.org/2812263003 Cr-Commit-Position: refs/heads/master@{#464121} Committed: https://chromium.googlesource.com/chromium/src/+/24e5d1ddee9fa61587b6f0279a25792d0208b9f1

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/threading/DEPS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
fdoray
Created Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp
3 years, 8 months ago (2017-04-12 16:43:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812263003/1
3 years, 8 months ago (2017-04-12 16:43:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/117888) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-12 16:48:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812263003/200001
3 years, 8 months ago (2017-04-12 17:29:07 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:200001) as https://chromium.googlesource.com/chromium/src/+/24e5d1ddee9fa61587b6f0279a25792d0208b9f1
3 years, 8 months ago (2017-04-12 19:59:11 UTC) #18
fdoray
3 years, 6 months ago (2017-05-30 14:26:26 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:200001) has been created in
https://codereview.chromium.org/2914633002/ by fdoray@chromium.org.

The reason for reverting is: Relanding the patch set after the effect of
reverting it has been analyzed..

Powered by Google App Engine
This is Rietveld 408576698