Check that Diagnostic subclasses are registered in presubmit.

Check that Diagnostic subclasses are registered in presubmit.

Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in tracing/tracing/value/diagnostics/all_diagnostics.html and ensure that they call Diagnostic.register().
***************


BUG=catapult:#3598

Review-Url: https://codereview.chromium.org/2914163002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b33525e9912492df600d3642dbeacfc4f33d92be

[benjhayden, 2017-06-01 07:11:36]

Description was changed from

==========
Check that Diagnostic subclasses are registered.

BUG=catapult:#3598
==========

to

==========
Check that Diagnostic subclasses are registered in presubmit.

BUG=catapult:#3598
==========

[benjhayden, 2017-06-01 07:48:02]

Description was changed from

==========
Check that Diagnostic subclasses are registered in presubmit.

BUG=catapult:#3598
==========

to

==========
Check that Diagnostic subclasses are registered in presubmit.


Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in
tracing/tracing/value/diagnostics/all_diagnostics.html
***************


BUG=catapult:#3598
==========

[benjhayden, 2017-06-01 07:50:55]

Description was changed from

==========
Check that Diagnostic subclasses are registered in presubmit.


Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in
tracing/tracing/value/diagnostics/all_diagnostics.html
***************


BUG=catapult:#3598
==========

to

==========
Check that Diagnostic subclasses are registered in presubmit.


Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in
tracing/tracing/value/diagnostics/all_diagnostics.html and ensure that they call
Diagnostic.register().
***************


BUG=catapult:#3598
==========

[benjhayden, 2017-06-01 07:51:37]

Patchset #1 (id:1) has been deleted

[benjhayden, 2017-06-01 07:51:42]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2017-06-01 07:51:49]

Patchset #1 (id:40001) has been deleted

[benjhayden, 2017-06-01 07:51:55]

Patchset #1 (id:60001) has been deleted

[benjhayden, 2017-06-01 07:56:18]

Patchset #1 (id:80001) has been deleted

[benjhayden, 2017-06-01 07:56:25]

Description was changed from

==========
Check that Diagnostic subclasses are registered in presubmit.


Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in
tracing/tracing/value/diagnostics/all_diagnostics.html and ensure that they call
Diagnostic.register().
***************


BUG=catapult:#3598
==========

to

==========
Check that Diagnostic subclasses are registered in presubmit.

Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in
tracing/tracing/value/diagnostics/all_diagnostics.html and ensure that they call
Diagnostic.register().
***************


BUG=catapult:#3598
==========

[benjhayden, 2017-06-01 07:56:44]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2017-06-01 07:56:45]

PTAL

[eakuefner, 2017-06-01 21:40:48]

lgtm

https://codereview.chromium.org/2914163002/diff/100001/tracing/bin/validate_a...
File tracing/bin/validate_all_diagnostics (right):

https://codereview.chromium.org/2914163002/diff/100001/tracing/bin/validate_a...
tracing/bin/validate_all_diagnostics:36: all_registered_diagnostics =
set(DiscoverDiagnostics(
Maybe just have DiscoverDiagnostics return a set?

https://codereview.chromium.org/2914163002/diff/100001/tracing/tracing/value/...
File tracing/tracing/value/diagnostics/discover_cmdline.html (right):

https://codereview.chromium.org/2914163002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/diagnostics/discover_cmdline.html:1: <!DOCTYPE html>
It bothers me that we have more than one discover_cmdline. They do pretty
different things so I don't think they need to share code, but maybe call this
one discover_diagnostics_cmdline?

[eakuefner, 2017-06-01 22:12:21]

https://codereview.chromium.org/2914163002/diff/100001/tracing/tracing/value/...
File tracing/tracing/value/diagnostics/discover_cmdline.html (right):

https://codereview.chromium.org/2914163002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/diagnostics/discover_cmdline.html:1: <!DOCTYPE html>
On 2017/06/01 at 21:40:48, eakuefner wrote:
> It bothers me that we have more than one discover_cmdline. They do pretty
different things so I don't think they need to share code, but maybe call this
one discover_diagnostics_cmdline?

nvm

[benjhayden, 2017-06-01 22:25:22]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-06-01 22:25:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2914163002/#ps120001
(title: "comments")

[commit-bot: I haz the power, 2017-06-01 22:25:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:49:54]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496355922205780,
"parent_rev": "17f9fabbc9e20dc8b747d1de7a54b1f55b307b26", "commit_rev":
"b33525e9912492df600d3642dbeacfc4f33d92be"}

[commit-bot: I haz the power, 2017-06-01 22:49:57]

Description was changed from

==========
Check that Diagnostic subclasses are registered in presubmit.

Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in
tracing/tracing/value/diagnostics/all_diagnostics.html and ensure that they call
Diagnostic.register().
***************


BUG=catapult:#3598
==========

to

==========
Check that Diagnostic subclasses are registered in presubmit.

Example output:
Failed validate_all_diagnostics: 

***************
These diagnostics are unregistered: Ownership. Please import their modules in
tracing/tracing/value/diagnostics/all_diagnostics.html and ensure that they call
Diagnostic.register().
***************


BUG=catapult:#3598

Review-Url: https://codereview.chromium.org/2914163002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-06-01 22:49:59]

Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...