Check that Diagnostic subclasses are registered in presubmit.

tracing/PRESUBMIT.py

Index: tracing/PRESUBMIT.py
diff --git a/tracing/PRESUBMIT.py b/tracing/PRESUBMIT.py
index 32f06c0831b4c26d43c760f1e21991d464f272a2..164b67fcc2390bcf871dd73206e7c398d7918bb8 100644
--- a/tracing/PRESUBMIT.py
+++ b/tracing/PRESUBMIT.py
@@ -25,6 +25,21 @@ def _CheckRegisteredMetrics(input_api, output_api):
   return results
 
 
+def _CheckRegisteredDiagnostics(input_api, output_api):
+  """Check that all Diagnostic subclasses are registered."""
+  results = []
+  tracing_dir = input_api.PresubmitLocalPath()
+  out, return_code = _RunArgs(
+      [input_api.python_executable,
+       input_api.os_path.join(tracing_dir, 'bin', 'validate_all_diagnostics')],
+      input_api)
+  if return_code:
+    results.append(output_api.PresubmitError(
+        'Failed validate_all_diagnostics: ', long_text=out))
+  return results
+
+
+
 def CheckChangeOnUpload(input_api, output_api):
   return _CheckChange(input_api, output_api)
 
@@ -51,6 +66,7 @@ def _CheckChange(input_api, output_api):
       pylintrc='../pylintrc'))
 
   results += _CheckRegisteredMetrics(input_api, output_api)
+  results += _CheckRegisteredDiagnostics(input_api, output_api)
 
   return results