Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tracing/tracing_project.py

Issue 2914163002: Check that Diagnostic subclasses are registered in presubmit. (Closed)
Patch Set: comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/diagnostics/ownership.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing_project.py
diff --git a/tracing/tracing_project.py b/tracing/tracing_project.py
index 38b5225895451ec09ac84da569f9f2be4dc45d79..3bdcb4e4d2e026fa249e78bafe55f5e06ad63cd2 100644
--- a/tracing/tracing_project.py
+++ b/tracing/tracing_project.py
@@ -87,6 +87,7 @@ class TracingProject(object):
mre_path = os.path.join(tracing_src_path, 'mre')
metrics_path = os.path.join(tracing_src_path, 'metrics')
+ diagnostics_path = os.path.join(tracing_src_path, 'value', 'diagnostics')
value_ui_path = os.path.join(tracing_src_path, 'value', 'ui')
metrics_ui_path = os.path.join(tracing_src_path, 'metrics', 'ui')
@@ -151,6 +152,16 @@ class TracingProject(object):
return [os.path.relpath(x, self.tracing_root_path)
for x in all_metrics_module_filenames]
+ def FindAllDiagnosticsModuleRelPaths(self):
+ all_filenames = _FindAllFilesRecursive([self.tracing_src_path])
+ all_diagnostics_module_filenames = []
+ for x in all_filenames:
+ if x.startswith(self.diagnostics_path) and not _IsFilenameATest(x):
+ all_diagnostics_module_filenames.append(x)
+ all_diagnostics_module_filenames.sort()
+ return [os.path.relpath(x, self.tracing_root_path)
+ for x in all_diagnostics_module_filenames]
+
def FindAllD8TestModuleRelPaths(self):
return self.FindAllTestModuleRelPaths(pred=self.IsD8CompatibleFile)
« no previous file with comments | « tracing/tracing/value/diagnostics/ownership.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698