[builtins] Begin removing CodeFactory accessors

[builtins] Begin removing CodeFactory accessors

BUG=v8:5737
Review-Url: https://codereview.chromium.org/2913783002
Cr-Commit-Position: refs/heads/master@{#45629}
Committed: https://chromium.googlesource.com/v8/v8/+/f710ba94b6e7ac5acd27fc60d8ffcb1d188700e9

[jgruber, 2017-05-30 14:21:28]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 14:21:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-30 14:22:45]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org, ishell@chromium.org

[jgruber, 2017-05-30 14:22:46]

Hey, finally getting around to removing duplicate CodeFactory accessors. This is
a first batch - PTAL

[commit-bot: I haz the power, 2017-05-30 14:56:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:56:54]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-31 07:26:47]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 07:26:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 07:35:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 07:35:35]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Camillo Bruni, 2017-05-31 08:59:22]

lgtm

[jgruber, 2017-05-31 09:21:44]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 09:21:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 09:51:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 09:51:54]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-31 09:53:25]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-05-31 09:53:26]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2913783002/#ps40001
(title: "V8_EXPORT_PRIVATE")

[commit-bot: I haz the power, 2017-05-31 09:53:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 09:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 09:56:26]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/42115)

[jgruber, 2017-05-31 09:58:53]

jgruber@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[jgruber, 2017-05-31 09:58:53]

+mstarzinger for compiler/, crankshaft/, full-codegen/, interpreter/.

[Igor Sheludko, 2017-05-31 10:00:56]

lgtm

[jgruber, 2017-05-31 10:34:49]

Description was changed from

==========
[builtins] Begin removing CodeFactory accessors

BUG=v8:5737
==========

to

==========
[builtins] Begin removing CodeFactory accessors

BUG=v8:5737
==========

[jgruber, 2017-05-31 10:34:49]

jgruber@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2017-05-31 11:51:33]

src/crankshaft/ LGTM, didn't look at the rest.

[Michael Starzinger, 2017-05-31 12:33:03]

LGTM.

[jgruber, 2017-05-31 12:35:57]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-05-31 12:36:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 12:40:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496234157150290,
"parent_rev": "e3da9102ddcd489852e8f939ad40da58da3fbb92", "commit_rev":
"f710ba94b6e7ac5acd27fc60d8ffcb1d188700e9"}

[commit-bot: I haz the power, 2017-05-31 12:40:22]

Description was changed from

==========
[builtins] Begin removing CodeFactory accessors

BUG=v8:5737
==========

to

==========
[builtins] Begin removing CodeFactory accessors

BUG=v8:5737

Review-Url: https://codereview.chromium.org/2913783002
Cr-Commit-Position: refs/heads/master@{#45629}
Committed:
https://chromium.googlesource.com/v8/v8/+/f710ba94b6e7ac5acd27fc60d8ffcb1d188...
==========

[commit-bot: I haz the power, 2017-05-31 12:40:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/f710ba94b6e7ac5acd27fc60d8ffcb1d188...