Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/code-stub-assembler.cc

Issue 2913783002: [builtins] Begin removing CodeFactory accessors (Closed)
Patch Set: V8_EXPORT_PRIVATE Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/compiler/effect-control-linearizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stub-assembler.cc
diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc
index 880c3d9968973dd81acf1ac8eaf638d295150a59..dc4a5acd574c6e046823cb723eee2f5889760279 100644
--- a/src/code-stub-assembler.cc
+++ b/src/code-stub-assembler.cc
@@ -2903,8 +2903,7 @@ Node* CodeStubAssembler::ToThisString(Node* context, Node* value,
BIND(&if_valueisnotnullorundefined);
{
// Convert the {value} to a String.
- Callable callable = CodeFactory::ToString(isolate());
- var_value.Bind(CallStub(callable, context, value));
+ var_value.Bind(CallBuiltin(Builtins::kToString, context, value));
Goto(&if_valueisstring);
}
}
@@ -7247,26 +7246,23 @@ Node* CodeStubAssembler::RelationalComparison(RelationalComparisonMode mode,
}
switch (mode) {
case kLessThan:
- result.Bind(CallStub(CodeFactory::StringLessThan(isolate()),
- context, lhs, rhs));
+ result.Bind(CallBuiltin(Builtins::kStringLessThan, context,
+ lhs, rhs));
Goto(&end);
break;
case kLessThanOrEqual:
- result.Bind(
- CallStub(CodeFactory::StringLessThanOrEqual(isolate()),
- context, lhs, rhs));
+ result.Bind(CallBuiltin(Builtins::kStringLessThanOrEqual,
+ context, lhs, rhs));
Goto(&end);
break;
case kGreaterThan:
- result.Bind(
- CallStub(CodeFactory::StringGreaterThan(isolate()),
- context, lhs, rhs));
+ result.Bind(CallBuiltin(Builtins::kStringGreaterThan, context,
+ lhs, rhs));
Goto(&end);
break;
case kGreaterThanOrEqual:
- result.Bind(
- CallStub(CodeFactory::StringGreaterThanOrEqual(isolate()),
- context, lhs, rhs));
+ result.Bind(CallBuiltin(Builtins::kStringGreaterThanOrEqual,
+ context, lhs, rhs));
Goto(&end);
break;
}
@@ -7735,8 +7731,8 @@ Node* CodeStubAssembler::Equal(Node* lhs, Node* rhs, Node* context,
{
// Both {lhs} and {rhs} are of type String, just do the
// string comparison then.
- Callable callable = CodeFactory::StringEqual(isolate());
- result.Bind(CallStub(callable, context, lhs, rhs));
+ result.Bind(
+ CallBuiltin(Builtins::kStringEqual, context, lhs, rhs));
if (var_type_feedback != nullptr) {
Node* lhs_feedback =
CollectFeedbackForString(lhs_instance_type);
@@ -8214,7 +8210,6 @@ Node* CodeStubAssembler::StrictEqual(Node* lhs, Node* rhs,
BIND(&if_rhsisstring);
{
- Callable callable = CodeFactory::StringEqual(isolate());
if (var_type_feedback != nullptr) {
Node* lhs_feedback =
CollectFeedbackForString(lhs_instance_type);
@@ -8222,7 +8217,8 @@ Node* CodeStubAssembler::StrictEqual(Node* lhs, Node* rhs,
CollectFeedbackForString(rhs_instance_type);
var_type_feedback->Bind(SmiOr(lhs_feedback, rhs_feedback));
}
- result.Bind(CallStub(callable, NoContextConstant(), lhs, rhs));
+ result.Bind(CallBuiltin(Builtins::kStringEqual,
+ NoContextConstant(), lhs, rhs));
Goto(&end);
}
« no previous file with comments | « src/code-factory.cc ('k') | src/compiler/effect-control-linearizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698