Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: src/builtins/builtins-string-gen.cc

Issue 2913783002: [builtins] Begin removing CodeFactory accessors (Closed)
Patch Set: V8_EXPORT_PRIVATE Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-promise-gen.cc ('k') | src/code-factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-string-gen.cc
diff --git a/src/builtins/builtins-string-gen.cc b/src/builtins/builtins-string-gen.cc
index d0f707bcec42ed5b3810e664c6887a8eb0a33a8e..5517b113d9013794fcc3ed175cc28d9b8ffed872 100644
--- a/src/builtins/builtins-string-gen.cc
+++ b/src/builtins/builtins-string-gen.cc
@@ -1144,9 +1144,8 @@ TF_BUILTIN(StringPrototypeReplace, StringBuiltinsAssembler) {
[=]() {
Node* const subject_string = ToString_Inline(context, receiver);
- Callable replace_callable = CodeFactory::RegExpReplace(isolate());
- return CallStub(replace_callable, context, search, subject_string,
- replace);
+ return CallBuiltin(Builtins::kRegExpReplace, context, search,
+ subject_string, replace);
},
[=](Node* fn) {
Callable call_callable = CodeFactory::Call(isolate());
@@ -1305,8 +1304,8 @@ TF_BUILTIN(StringPrototypeSlice, StringBuiltinsAssembler) {
RequireObjectCoercible(context, receiver, "String.prototype.slice");
// 2. Let S be ? ToString(O).
- Callable tostring_callable = CodeFactory::ToString(isolate());
- Node* const subject_string = CallStub(tostring_callable, context, receiver);
+ Node* const subject_string =
+ CallBuiltin(Builtins::kToString, context, receiver);
// 3. Let len be the number of elements in S.
Node* const length = LoadStringLength(subject_string);
@@ -1385,9 +1384,8 @@ TF_BUILTIN(StringPrototypeSplit, StringBuiltinsAssembler) {
[=]() {
Node* const subject_string = ToString_Inline(context, receiver);
- Callable split_callable = CodeFactory::RegExpSplit(isolate());
- return CallStub(split_callable, context, separator, subject_string,
- limit);
+ return CallBuiltin(Builtins::kRegExpSplit, context, separator,
+ subject_string, limit);
},
[=](Node* fn) {
Callable call_callable = CodeFactory::Call(isolate());
« no previous file with comments | « src/builtins/builtins-promise-gen.cc ('k') | src/code-factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698